components/safe_browsing/password_protection/DEPS - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/DEPS

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: clean up DEPS file Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing/password_protection/DEPS

diff --git a/components/safe_browsing/password_protection/DEPS b/components/safe_browsing/password_protection/DEPS

index f04e7f6794a557d26bdaa8b0415bdb477ca7a4fa..04ee58694da1ca40004cfb63dc94863b25dbf8f8 100644

--- a/components/safe_browsing/password_protection/DEPS

+++ b/components/safe_browsing/password_protection/DEPS

@@ -1,12 +1,7 @@

include_rules = [

- "-content",

"+components/content_settings/core/browser",

"+components/history/core/browser",

- "+components/safe_browsing/csd.pb.h",

- "+components/safe_browsing_db",

Nathan Parker 2017/05/31 22:40:55 how is this not needed? Or is it included from the

vakh (use Gerrit instead) 2017/06/01 00:02:25 Yes, but I appreciate the RED color :)

Jialiu Lin 2017/06/01 01:22:01 Acknowledged.

Jialiu Lin 2017/06/01 01:22:01 Yes, these are already included in the components/

"+components/sync_preferences/testing_pref_service_syncable.h",

- "+content/public/browser",

"+content/public/test",

- "+net",

]