Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2912373002: [iOS] Stop swizzling the |init| method of CameraController. (Closed)

Created:
3 years, 6 months ago by jif
Modified:
3 years, 6 months ago
Reviewers:
baxley, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Stop swizzling the init of CameraController. Instead of swizzling the init method of CameraController, the EG tests swizzle a method returning an autoreleased instance of a CameraController. BUG=None. Review-Url: https://codereview.chromium.org/2912373002 Cr-Commit-Position: refs/heads/master@{#475893} Committed: https://chromium.googlesource.com/chromium/src/+/3f9a1acfe86c090f44bb6c7cb168540f1bdab3cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M ios/chrome/browser/ui/qr_scanner/camera_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/camera_controller.mm View 2 chunks +11 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jif
ptal
3 years, 6 months ago (2017-05-31 13:07:41 UTC) #3
stkhapugin
lgtm
3 years, 6 months ago (2017-05-31 13:13:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912373002/1
3 years, 6 months ago (2017-05-31 13:14:11 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 13:24:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f9a1acfe86c090f44bb6c7cb168...

Powered by Google App Engine
This is Rietveld 408576698