Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Issue 2912343002: Add BuildBotClient to abstract http/logdog access (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add BuildBotClient to abstract http/logdog access + support error handling for logdog R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/0e61716730e6016dca1b02c7dca9b44115b6fa67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -71 lines) Patch
M tools/gardening/bin/compare_failures.dart View 7 chunks +17 lines, -18 lines 0 comments Download
M tools/gardening/bin/current_summary.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M tools/gardening/bin/find_timeouts.dart View 5 chunks +19 lines, -18 lines 0 comments Download
M tools/gardening/lib/src/buildbot_data.dart View 6 chunks +113 lines, -19 lines 0 comments Download
M tools/gardening/lib/src/buildbot_loading.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/cache.dart View 2 chunks +4 lines, -0 lines 0 comments Download
A tools/gardening/lib/src/client.dart View 1 chunk +92 lines, -0 lines 0 comments Download
M tools/gardening/lib/src/logdog.dart View 2 chunks +62 lines, -9 lines 0 comments Download
M tools/gardening/lib/src/util.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 6 months ago (2017-05-31 09:06:47 UTC) #3
floitsch
LGTM! great work.
3 years, 6 months ago (2017-05-31 15:08:35 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-01 08:02:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e61716730e6016dca1b02c7dca9b44115b6fa67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698