Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: tools/gardening/lib/src/buildbot_structures.dart

Issue 2912343002: Add BuildBotClient to abstract http/logdog access (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/lib/src/buildbot_loading.dart ('k') | tools/gardening/lib/src/cache.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/buildbot_structures.dart
diff --git a/tools/gardening/lib/src/buildbot_structures.dart b/tools/gardening/lib/src/buildbot_structures.dart
index eee03a5290b06087c9f1aa946f189e684785d62e..3cbd500689e636ec6d8fe1607dede5edeffdda76 100644
--- a/tools/gardening/lib/src/buildbot_structures.dart
+++ b/tools/gardening/lib/src/buildbot_structures.dart
@@ -15,8 +15,8 @@ class BuildUri {
final String suffix;
factory BuildUri(Uri uri) {
- List<String> parts =
- split(uri.path, ['/builders/', '/builds/', '/steps/', '/logs/']);
+ List<String> parts = split(Uri.decodeFull(uri.path),
+ ['/builders/', '/builds/', '/steps/', '/logs/']);
String botName = parts[1];
int buildNumber = int.parse(parts[2]);
String stepName = parts[3];
@@ -35,6 +35,8 @@ class BuildUri {
return new BuildUri.fromData(botName, buildNumber, stepName);
}
+ int get absoluteBuildNumber => buildNumber >= 0 ? buildNumber : null;
+
String get shortBuildName => '$botName/$stepName';
String get buildName =>
« no previous file with comments | « tools/gardening/lib/src/buildbot_loading.dart ('k') | tools/gardening/lib/src/cache.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698