Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2912333002: Improve and fix counter texts (Closed)

Created:
3 years, 6 months ago by msramek
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Improve and fix counter texts Change all CBD counter texts to upper case first letter. Replace cookie counter text for consistency with other counters. BUG=681523 Review-Url: https://codereview.chromium.org/2910983002 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#475344} Committed: https://chromium.googlesource.com/chromium/src/+/818885262b08d3e4439c8ae538cec8090b5cdf2c Review-Url: https://codereview.chromium.org/2910983002 Cr-Original-Original-Commit-Position: refs/heads/master@{#475457} Committed: https://chromium.googlesource.com/chromium/src/+/67618346e22720b39a26ff20d7b94f9b10cd5f22 Review-Url: https://codereview.chromium.org/2910983002 Cr-Original-Commit-Position: refs/heads/master@{#475511} Review-Url: https://codereview.chromium.org/2912333002 . Cr-Commit-Position: refs/branch-heads/3112@{#49} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3e5b22f782de5cb8909dbca7936964d30514ff55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/browsing_data/core/browsing_data_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browsing_data/core/browsing_data_utils_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/browsing_data_strings.grdp View 2 chunks +13 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
3 years, 6 months ago (2017-05-31 08:49:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e5b22f782de5cb8909dbca7936964d30514ff55.

Powered by Google App Engine
This is Rietveld 408576698