Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: trunk/Source/core/editing/ReplaceSelectionCommand.cpp

Issue 291233003: Revert 174382 "Oilpan: make DocumentFragment a heap allocated ob..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/editing/ReplaceSelectionCommand.h ('k') | trunk/Source/core/editing/markup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/editing/ReplaceSelectionCommand.cpp
===================================================================
--- trunk/Source/core/editing/ReplaceSelectionCommand.cpp (revision 174395)
+++ trunk/Source/core/editing/ReplaceSelectionCommand.cpp (working copy)
@@ -63,9 +63,8 @@
// --- ReplacementFragment helper class
-class ReplacementFragment FINAL {
+class ReplacementFragment {
WTF_MAKE_NONCOPYABLE(ReplacementFragment);
- STACK_ALLOCATED();
public:
ReplacementFragment(Document*, DocumentFragment*, const VisibleSelection&);
@@ -88,8 +87,8 @@
void insertNodeBefore(PassRefPtr<Node> node, Node* refNode);
- RefPtrWillBeMember<Document> m_document;
- RefPtrWillBeMember<DocumentFragment> m_fragment;
+ RefPtr<Document> m_document;
+ RefPtr<DocumentFragment> m_fragment;
bool m_hasInterchangeNewlineAtStart;
bool m_hasInterchangeNewlineAtEnd;
};
@@ -356,7 +355,7 @@
m_lastNodeInserted = &newNode;
}
-ReplaceSelectionCommand::ReplaceSelectionCommand(Document& document, PassRefPtrWillBeRawPtr<DocumentFragment> fragment, CommandOptions options, EditAction editAction)
+ReplaceSelectionCommand::ReplaceSelectionCommand(Document& document, PassRefPtr<DocumentFragment> fragment, CommandOptions options, EditAction editAction)
: CompositeEditCommand(document)
, m_selectReplacement(options & SelectReplacement)
, m_smartReplace(options & SmartReplace)
« no previous file with comments | « trunk/Source/core/editing/ReplaceSelectionCommand.h ('k') | trunk/Source/core/editing/markup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698