Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 291233003: Revert 174382 "Oilpan: make DocumentFragment a heap allocated ob..." (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
sof
CC:
blink-reviews
Visibility:
Public.

Description

Revert 174382 "Oilpan: make DocumentFragment a heap allocated ob..." Suspect this caused assertion failures in inspector/split-view.html, which may indicate a deeper problem. See Issue 357163. > Oilpan: make DocumentFragment a heap allocated object. > > R=wibling@chromium.org,zerny@chromium.org,haraken@chromium.org > BUG=357163 > > Review URL: https://codereview.chromium.org/289273002 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -102 lines) Patch
M trunk/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/dom/DocumentFragment.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/dom/Range.h View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/Source/core/dom/Range.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M trunk/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/Editor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/editing/Editor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/editing/EditorCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/editing/MoveSelectionCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/editing/MoveSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/ReplaceSelectionCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/editing/ReplaceSelectionCommand.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/Source/core/editing/markup.h View 2 chunks +7 lines, -8 lines 0 comments Download
M trunk/Source/core/editing/markup.cpp View 13 chunks +19 lines, -19 lines 0 comments Download
M trunk/Source/core/events/TextEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/events/TextEvent.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/Source/core/html/HTMLElement.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/HTMLElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/html/track/vtt/VTTCue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/html/track/vtt/VTTCue.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/Source/core/html/track/vtt/VTTParser.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/track/vtt/VTTParser.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/page/DragController.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/Source/core/page/DragData.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/page/DragData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/xml/XSLTProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-20 18:49:48 UTC) #1
Ken Russell (switch to Gerrit)
Committed patchset #1 manually as r174396.
6 years, 7 months ago (2014-05-20 18:51:42 UTC) #2
sof
On 2014/05/20 18:51:42, Ken Russell wrote: > Committed patchset #1 manually as r174396. thanks, lgtm. ...
6 years, 7 months ago (2014-05-20 21:46:24 UTC) #3
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-20 22:16:58 UTC) #4
Message was sent while issue was closed.
On 2014/05/20 21:46:24, sof wrote:
> On 2014/05/20 18:51:42, Ken Russell wrote:
> > Committed patchset #1 manually as r174396.
> 
> thanks, lgtm. will investigate in the morning, but i can repro the failure
with
> or without this CL.

Apologies, I see the test is still asserting even after this revert in
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%...
. I'm continuing to investigate. Can you take care of re-landing your CL?

Powered by Google App Engine
This is Rietveld 408576698