Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 291233002: Re-landing "Suppressed screen rotation notifications triggeres by the accelerometer." (Closed)

Created:
6 years, 7 months ago by bruthig
Modified:
6 years, 7 months ago
Reviewers:
flackr, sadrul
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-landing "Suppressed screen rotation notifications triggeres by the accelerometer." Original review: https://codereview.chromium.org/267743010/ BUG=364949 Test=MaximizeModeControllerTest.BlockRotationNotifications TBR=flackr TBR=sadrul Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271808

Patch Set 1 #

Patch Set 2 : ifdef'ed BlockRotationNotification test so it only runs on ChromeOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -8 lines) Patch
M ash/system/chromeos/tray_display.cc View 3 chunks +10 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.h View 4 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 5 chunks +70 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bruthig
6 years, 7 months ago (2014-05-20 18:10:16 UTC) #1
flackr
Patch set 1 is the original patch, patch set 2 lgtm.
6 years, 7 months ago (2014-05-20 18:30:40 UTC) #2
bruthig
The CQ bit was checked by bruthig@chromium.org
6 years, 7 months ago (2014-05-20 18:31:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruthig@chromium.org/291233002/20001
6 years, 7 months ago (2014-05-20 18:32:03 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:00:26 UTC) #5
Message was sent while issue was closed.
Change committed as 271808

Powered by Google App Engine
This is Rietveld 408576698