Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2912293002: Revert of Compute tail time from Biquad coefficients (Closed)

Created:
3 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 6 months ago
Reviewers:
hongchan, Raymond Toy
CC:
chromium-reviews, haraken, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Compute tail time from Biquad coefficients (patchset #7 id:120001 of https://codereview.chromium.org/2862373002/ ) Reason for revert: The added layout tests are failing on "WebKit Linux Trusty MSAN" bot. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/1242 Original issue's description: > Compute tail time from Biquad coefficients > > Instead of using a fixed tail time of 200 ms for all biquad filters, > we compute the actual tail time from filter coefficients. Many > typical filters in applications have a tail time of 10 ms or less. > This allows biquads and downstream nodes to stop processing much sooner > than what currently happens, reducing CPU usage and allowing GC to > collect nodes sooner. > > BUG=612215 > TEST= > > Review-Url: https://codereview.chromium.org/2862373002 > Cr-Commit-Position: refs/heads/master@{#475632} > Committed: https://chromium.googlesource.com/chromium/src/+/0be695dcb495cade0ed5c4b70aba95eb3dce49bd TBR=hongchan@chromium.org,rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612215 Review-Url: https://codereview.chromium.org/2912293002 Cr-Commit-Position: refs/heads/master@{#475822} Committed: https://chromium.googlesource.com/chromium/src/+/cd4b3bdb8a5e9194b8410df13921b16248dc7009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1277 lines) Patch
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-allpass.html View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-bandpass.html View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-highpass.html View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-highshelf.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-lowpass.html View 1 chunk +0 lines, -168 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-lowshelf.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-notch.html View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/tail-time-peaking.html View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/BiquadFilter/test-tail-time.js View 1 chunk +0 lines, -90 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp View 3 chunks +8 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Biquad.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Biquad.cpp View 1 chunk +0 lines, -294 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tyoshino (SeeGerritForStatus)
Created Revert of Compute tail time from Biquad coefficients
3 years, 6 months ago (2017-05-31 06:04:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912293002/1
3 years, 6 months ago (2017-05-31 06:04:59 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 06:05:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd4b3bdb8a5e9194b8410df13921...

Powered by Google App Engine
This is Rietveld 408576698