Explicitly setting story names for the blink story sets.

Explicitly setting story names for the blink story sets.

BUG=chromium:720002
Review-Url: https://codereview.chromium.org/2912253002
Cr-Commit-Position: refs/heads/master@{#477835}
Committed: https://chromium.googlesource.com/chromium/src/+/1e7663cfd51fbf5f3a744351f0ae45df271b0da4

[ashleymarie1, 2017-05-31 03:12:40]

Description was changed from

==========
Explicitly setting story names for the blink story sets.

BUG=chromium:720002
==========

to

==========
Explicitly setting story names for the blink story sets.

BUG=chromium:720002
==========

[ashleymarie1, 2017-05-31 03:12:40]

ashleymarie@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, nednguyen@google.com,
rnephew@chromium.org, yukishiino@chromium.org

[haraken, 2017-05-31 04:21:14]

LGTM

[nednguyen, 2017-05-31 10:27:33]

On 2017/05/31 04:21:14, haraken wrote:
> LGTM

lgtm, though do you know why the name of the story failure in buildbot is the
full path name?

See blink_perf.bindings.reference in
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%2...

[ashleymarie1, 2017-05-31 14:24:36]

On 2017/05/31 10:27:33, nednguyen wrote:
> On 2017/05/31 04:21:14, haraken wrote:
> > LGTM
> 
> lgtm, though do you know why the name of the story failure in buildbot is the
> full path name?
> 
> See blink_perf.bindings.reference in
>
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%2...
Interesting... Any idea where buildbot gets its names from? It looks like this
case should actually be shortening the url to set that as the name to remove the
common prefixes for the name so I'll need to update this anyways but the
display_name prior to this change shouldn't be the full path...

[ashleymarie1, 2017-05-31 14:52:32]

On 2017/05/31 14:24:36, ashleymarie1 wrote:
> On 2017/05/31 10:27:33, nednguyen wrote:
> > On 2017/05/31 04:21:14, haraken wrote:
> > > LGTM
> > 
> > lgtm, though do you know why the name of the story failure in buildbot is
the
> > full path name?
> > 
> > See blink_perf.bindings.reference in
> >
>
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%2...
> Interesting... Any idea where buildbot gets its names from? It looks like this
> case should actually be shortening the url to set that as the name to remove
the
> common prefixes for the name so I'll need to update this anyways but the
> display_name prior to this change shouldn't be the full path...

Okay so I updated the code to generate the short version of the path as the name
I'll do the buildbot name change in a separate cl

[nednguyen, 2017-05-31 14:54:48]

On 2017/05/31 14:52:32, ashleymarie1 wrote:
> On 2017/05/31 14:24:36, ashleymarie1 wrote:
> > On 2017/05/31 10:27:33, nednguyen wrote:
> > > On 2017/05/31 04:21:14, haraken wrote:
> > > > LGTM
> > > 
> > > lgtm, though do you know why the name of the story failure in buildbot is
> the
> > > full path name?
> > > 
> > > See blink_perf.bindings.reference in
> > >
> >
>
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%2...
> > Interesting... Any idea where buildbot gets its names from? It looks like
this
> > case should actually be shortening the url to set that as the name to remove
> the
> > common prefixes for the name so I'll need to update this anyways but the
> > display_name prior to this change shouldn't be the full path...
> 
> Okay so I updated the code to generate the short version of the path as the
name
> I'll do the buildbot name change in a separate cl

sgtm. Just want to make sure that this doesn't require name migration?

[bashi, 2017-05-31 23:03:28]

lgtm

[ashleymarie1, 2017-05-31 23:58:07]

On 2017/05/31 14:54:48, nednguyen wrote:
> On 2017/05/31 14:52:32, ashleymarie1 wrote:
> > On 2017/05/31 14:24:36, ashleymarie1 wrote:
> > > On 2017/05/31 10:27:33, nednguyen wrote:
> > > > On 2017/05/31 04:21:14, haraken wrote:
> > > > > LGTM
> > > > 
> > > > lgtm, though do you know why the name of the story failure in buildbot
is
> > the
> > > > full path name?
> > > > 
> > > > See blink_perf.bindings.reference in
> > > >
> > >
> >
>
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20One%2...
> > > Interesting... Any idea where buildbot gets its names from? It looks like
> this
> > > case should actually be shortening the url to set that as the name to
remove
> > the
> > > common prefixes for the name so I'll need to update this anyways but the
> > > display_name prior to this change shouldn't be the full path...
> > 
> > Okay so I updated the code to generate the short version of the path as the
> name
> > I'll do the buildbot name change in a separate cl
> 
> sgtm. Just want to make sure that this doesn't require name migration?

Yep; I created a bug to track the buildbot name change but it actually looks
like it will be resolved by explicitly setting the story names (yay!)
The names in this cl are being generated the exact same way they were being
generated before in story.display_name so I don't believe this will require a
migration. It's probably a good idea to submit a similar benchmark change for
another benchmark with way fewer stories that has display_names generated in
this way just in case my understanding is incorrect. (I'd rather do a few
migrations as opposed to all of blink.* if I'm incorrect). So let's hold off on
submitting this for a day while I verify

[Yuki, 2017-06-01 06:50:12]

LGTM.

[ashleymarie1, 2017-06-07 20:15:50]

The CQ bit was checked by ashleymarie@chromium.org

[ashleymarie1, 2017-06-07 20:15:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2912253002/#ps20001
(title: "Explicitly setting story names for the blink story sets.")

[commit-bot: I haz the power, 2017-06-07 20:16:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:31:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ashleymarie1, 2017-06-07 23:03:57]

The CQ bit was checked by ashleymarie@chromium.org

[commit-bot: I haz the power, 2017-06-07 23:04:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 00:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496876637893030,
"parent_rev": "2deb8c3767fbb87c7fac334eda0624bc838903df", "commit_rev":
"1e7663cfd51fbf5f3a744351f0ae45df271b0da4"}

[commit-bot: I haz the power, 2017-06-08 00:39:33]

Description was changed from

==========
Explicitly setting story names for the blink story sets.

BUG=chromium:720002
==========

to

==========
Explicitly setting story names for the blink story sets.

BUG=chromium:720002

Review-Url: https://codereview.chromium.org/2912253002
Cr-Commit-Position: refs/heads/master@{#477835}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e7663cfd51fbf5f3a744351f0ae...
==========

[commit-bot: I haz the power, 2017-06-08 00:39:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e7663cfd51fbf5f3a744351f0ae...