Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

What this CL does is removes some of these special cases in favor of just
returning the uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369
Review-Url: https://codereview.chromium.org/2912243002
Cr-Commit-Position: refs/heads/master@{#477216}
Committed: https://chromium.googlesource.com/chromium/src/+/0e42c06947d8e001c30bdc0efafefedd8afa2256

[dougt, 2017-05-31 02:42:40]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 02:43:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-05-31 02:45:01]

Description was changed from

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specfic
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

This is a follow up from issue 2909853002.

BUG=703369
==========

to

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

This also changes the string result of canvas elements with
ui::AX_ATTR_CANVAS_HAS_FALLBACK set.  In this case, we will also return the
uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369
==========

[dougt, 2017-05-31 03:11:23]

Description was changed from

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

This also changes the string result of canvas elements with
ui::AX_ATTR_CANVAS_HAS_FALLBACK set.  In this case, we will also return the
uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369
==========

to

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

What this CL does is removes some of these special cases in favor of just
returning the uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369
==========

[commit-bot: I haz the power, 2017-05-31 04:33:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 04:33:22]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dougt, 2017-05-31 04:45:54]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 04:46:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 06:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 06:02:45]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-05-31 14:20:40]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dougt, 2017-05-31 14:20:41]

Hi dmazzoni,

This fixes most of the todo's in StringOverrideForMSAARole().

This leaves AX_ROLE_GENERIC_CONTAINER todo alone.  At this point, it is not
clear to me why we don't just map AX_ROLE_GENERIC_CONTAINER to
ROLE_SYSTEM_GROUPING.

PTAL

[dmazzoni, 2017-06-06 04:46:15]

lgtm

I think it's fine if AX_ROLE_GENERIC_CONTAINER maps
to GROUPING on Windows.

[dougt, 2017-06-06 04:47:43]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-06-06 04:47:54]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:47:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 06:29:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496724463749580,
"parent_rev": "7aedf600f25ab27208dd388d287161d207807ac4", "commit_rev":
"0e42c06947d8e001c30bdc0efafefedd8afa2256"}

[commit-bot: I haz the power, 2017-06-06 06:30:02]

Description was changed from

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

What this CL does is removes some of these special cases in favor of just
returning the uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369
==========

to

==========
Fix todo's in AXPlatformNodeWin::get_accRole related to string results.

For historical reasons, AXPlatformNodeWin::get_accRole can return a string
which can containing the HTML tag name as the MSAA role, rather than a int.

In some cases, we special cased roles such that they alway returned a specific
string instead of the underlying HTML tag name. For example, AX_ROLE_PARAGRAPH
always returned upper case "P".

What this CL does is removes some of these special cases in favor of just
returning the uppercase of the HTML tag name.

This is a follow up from issue 2909853002.

BUG=703369

Review-Url: https://codereview.chromium.org/2912243002
Cr-Commit-Position: refs/heads/master@{#477216}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e42c06947d8e001c30bdc0efafe...
==========

[commit-bot: I haz the power, 2017-06-06 06:30:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e42c06947d8e001c30bdc0efafe...