Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2912233002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::InsertLineBreak/ParagraphSeparator (Closed)

Created:
3 years, 6 months ago by Xiaocheng
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::InsertLineBreak/ParagraphSeparator This patch prunes two call sites of the deprecated function, which is safe because layout is already updated at their caller, Editor::HandleTextEvent(). BUG=698633 Review-Url: https://codereview.chromium.org/2912233002 Cr-Commit-Position: refs/heads/master@{#475793} Committed: https://chromium.googlesource.com/chromium/src/+/d33e6ecdcbe2218aadc0bdd80921c579dcf70cad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Xiaocheng
PTAL.
3 years, 6 months ago (2017-05-31 02:31:20 UTC) #10
yosin_UTC9
lgtm
3 years, 6 months ago (2017-05-31 03:36:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912233002/1
3 years, 6 months ago (2017-05-31 03:36:56 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 04:18:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d33e6ecdcbe2218aadc0bdd80921...

Powered by Google App Engine
This is Rietveld 408576698