Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2912163002: Remove --host-resolver-retry-attempts. (Closed)

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --host-resolver-retry-attempts. This doesn't seem to have seen a whole lot of use. BUG=727894 Review-Url: https://codereview.chromium.org/2912163002 Cr-Commit-Position: refs/heads/master@{#475704} Committed: https://chromium.googlesource.com/chromium/src/+/9a6e17b873b960f3ec952187af2700b718e64580

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -14 lines 1 comment Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mmenke
https://codereview.chromium.org/2912163002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/2912163002/diff/1/chrome/browser/io_thread.cc#newcode224 chrome/browser/io_thread.cc:224: net::HostResolver::Options options; I'm leaving max_retry_attempts in options, though it's ...
3 years, 6 months ago (2017-05-30 21:46:46 UTC) #4
eroman
lgtm
3 years, 6 months ago (2017-05-30 22:21:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912163002/1
3 years, 6 months ago (2017-05-30 22:23:15 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 00:29:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a6e17b873b960f3ec952187af27...

Powered by Google App Engine
This is Rietveld 408576698