Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2912133003: Revert of [DMC #17] Make TextMatchMarkers constructible in single step (Closed)

Created:
3 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DMC #17] Make TextMatchMarkers constructible in single step (patchset #4 id:60001 of https://codereview.chromium.org/2905753002/ ) Reason for revert: This broke the build. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/201575 Original issue's description: > Make TextMatchMarkers constructible in single step > > Currently, we only construct instances of TextMatchMarker (previously > RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling > TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this > so callers directly construct instances of TextMatchMarker. This sets us up to > eventually move the storage and accessor methods for whether or not the marker > is active out of DocumentMarker and into TextMatchMarker. > > BUG=707867 > > Review-Url: https://codereview.chromium.org/2905753002 > Cr-Commit-Position: refs/heads/master@{#475724} > Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d TBR=yosin@chromium.org,xiaochengh@chromium.org,rlanday@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707867 Review-Url: https://codereview.chromium.org/2912133003 Cr-Commit-Position: refs/heads/master@{#475732} Committed: https://chromium.googlesource.com/chromium/src/+/182740235efc11d585d6710485d66fff4fcf84ae

Patch Set 1 #

Messages

Total messages: 7 (4 generated)
tyoshino (SeeGerritForStatus)
Created Revert of [DMC #17] Make TextMatchMarkers constructible in single step
3 years, 6 months ago (2017-05-31 01:48:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912133003/1
3 years, 6 months ago (2017-05-31 01:49:07 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:49:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/182740235efc11d585d6710485d6...

Powered by Google App Engine
This is Rietveld 408576698