Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2912133002: Add incognito mode strings for ARC's intent picker (Closed)

Created:
3 years, 6 months ago by djacobo
Modified:
3 years, 5 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add incognito mode strings for ARC's intent picker Adding 4 strings that will be used for incognito mode on ARC's intent picker. Bug: 678141 Test: Build Review-Url: https://codereview.chromium.org/2912133002 Cr-Commit-Position: refs/heads/master@{#478708} Committed: https://chromium.googlesource.com/chromium/src/+/63eaa6bb8b2bda28c00862d8b4275f735ee57e9b

Patch Set 1 #

Patch Set 2 : Changed texts to reuse the ones in crrev.com/2354613005 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
djacobo
yusukes@ mind taking a look? already chatted with Jenn/Hiro about this and we want to ...
3 years, 6 months ago (2017-06-10 01:00:47 UTC) #8
Yusuke Sato
lgtm
3 years, 6 months ago (2017-06-12 16:43:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912133002/20001
3 years, 6 months ago (2017-06-12 17:41:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/63eaa6bb8b2bda28c00862d8b4275f735ee57e9b
3 years, 6 months ago (2017-06-12 19:06:34 UTC) #16
Matt Giuca
3 years, 5 months ago (2017-06-28 00:34:49 UTC) #17
Message was sent while issue was closed.
On 2017/06/12 19:06:34, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/63eaa6bb8b2bda28c00862d8b427...

Hmm, duplicating 4 strings from
chrome/android/java/strings/android_chrome_strings.grd isn't great (they may get
out of sync, be differently translated, etc).

Obviously you can't use the strings from android_chrome_strings on non-Android.
I'll see if I can get the Android Java code to use this version and delete the
strings in android_chrome_strings.grd.

Powered by Google App Engine
This is Rietveld 408576698