Issue 291213002: Revert 271677 "Web MIDI: add permission infobar icon for Android"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291213002: Revert 271677 "Web MIDI: add permission infobar icon for Android" (Closed)

Created:
6 years, 7 months ago by Nicolas Zea

Modified:
6 years, 7 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 271677 "Web MIDI: add permission infobar icon for Android" Breaks android builder due to PNG corruption from ASCII conversion (same error as on try job). http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=58007 > Web MIDI: add permission infobar icon for Android > > On Android, permission infobar appears for Web MIDI permission, > but correct icon is not used. This change add a proper icon. > > Submit with NOTRY=true since it contains binary files and the patch > fails on try. > > BUG=339767 > NOTRY=true > > Review URL: https://codereview.chromium.org/292743004 TBR=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271697

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	D	trunk/src/chrome/android/java/res/drawable/infobar_midi.png	View		Binary file		0 comments	Download
	M	trunk/src/chrome/browser/android/resource_id.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Nicolas Zea

6 years, 7 months ago (2014-05-20 17:44:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r271697 (tree was closed).