Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 291213002: Revert 271677 "Web MIDI: add permission infobar icon for Android" (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271677 "Web MIDI: add permission infobar icon for Android" Breaks android builder due to PNG corruption from ASCII conversion (same error as on try job). http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=58007 > Web MIDI: add permission infobar icon for Android > > On Android, permission infobar appears for Web MIDI permission, > but correct icon is not used. This change add a proper icon. > > Submit with NOTRY=true since it contains binary files and the patch > fails on try. > > BUG=339767 > NOTRY=true > > Review URL: https://codereview.chromium.org/292743004 TBR=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
D trunk/src/chrome/android/java/res/drawable/infobar_midi.png View Binary file 0 comments Download
M trunk/src/chrome/browser/android/resource_id.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
6 years, 7 months ago (2014-05-20 17:44:18 UTC) #1
Nicolas Zea
6 years, 7 months ago (2014-05-20 17:44:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271697 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698