Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 292743004: Web MIDI: add permission infobar icon for Android (Closed)

Created:
6 years, 7 months ago by Takashi Toyoshima
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Resubmit: Web MIDI: add permission infobar icon for Android Changes from the first submit: - Submit a binary image file separately by dcommit in advance Original description: On Android, permission infobar appears for Web MIDI permission, but correct icon is not used. This change add a proper icon. BUG=339767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271955

Patch Set 1 #

Patch Set 2 : resubmit (png is submitted separately) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/android/resource_id.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Takashi Toyoshima
Please take a look.
6 years, 7 months ago (2014-05-20 02:32:57 UTC) #1
Miguel Garcia
lgtm
6 years, 7 months ago (2014-05-20 07:43:55 UTC) #2
Miguel Garcia
On 2014/05/20 07:43:55, Miguel Garcia wrote: > lgtm still lgtm but other infobars have buttons ...
6 years, 7 months ago (2014-05-20 07:46:34 UTC) #3
Takashi Toyoshima
I run Chromium on Nexus5 for phone and New Nexus7 for tablet, and they shows ...
6 years, 7 months ago (2014-05-20 08:13:25 UTC) #4
Takashi Toyoshima
Filed a bug for different resolution icons: http://crbug.com/375165
6 years, 7 months ago (2014-05-20 08:31:17 UTC) #5
bulach
lgtm
6 years, 7 months ago (2014-05-20 11:03:41 UTC) #6
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-20 11:42:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/292743004/1
6 years, 7 months ago (2014-05-20 11:43:28 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 14:44:22 UTC) #9
Takashi Toyoshima
The CQ bit was unchecked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-20 14:46:51 UTC) #10
Takashi Toyoshima
binary patch for png seems not to work in try jobs, then android builds fail. ...
6 years, 7 months ago (2014-05-20 14:48:29 UTC) #11
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-20 14:49:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/292743004/1
6 years, 7 months ago (2014-05-20 14:51:10 UTC) #13
commit-bot: I haz the power
Change committed as 271677
6 years, 7 months ago (2014-05-20 17:17:29 UTC) #14
boliu
I believe commit queue still can't submit binary files either. I think you can dcommit ...
6 years, 7 months ago (2014-05-20 18:06:07 UTC) #15
Takashi Toyoshima
Thanks bollu. I submitted the png by dcommit, and now I try CQ again.
6 years, 7 months ago (2014-05-21 02:09:10 UTC) #16
Takashi Toyoshima
The CQ bit was checked by toyoshim@chromium.org
6 years, 7 months ago (2014-05-21 02:09:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/292743004/20001
6 years, 7 months ago (2014-05-21 02:10:03 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:16:18 UTC) #19
Message was sent while issue was closed.
Change committed as 271955

Powered by Google App Engine
This is Rietveld 408576698