Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2912103002: Avoid failed requests in inline login UI browser tests. (Closed)

Created:
3 years, 6 months ago by msarda
Modified:
3 years, 6 months ago
CC:
chromium-reviews, hiroshige+script_chromium.org, kouhei+script_chromium.org, kochi+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid failed requests in inline login UI browser tests. This CL change the inline login UI browser tests to respond with an empty HTML response when there is request to load any GAIA login page. This ensures that loading the GAIA login page will not be aborted. BUG=722164 Review-Url: https://codereview.chromium.org/2912103002 Cr-Commit-Position: refs/heads/master@{#475529} Committed: https://chromium.googlesource.com/chromium/src/+/844c8727744ff0b46ae67786feaac9b81f790b10

Patch Set 1 #

Patch Set 2 : Ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
msarda
Roger: Please take a look.
3 years, 6 months ago (2017-05-30 13:57:00 UTC) #5
Roger Tawa OOO till Jul 10th
lgtm
3 years, 6 months ago (2017-05-30 14:21:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912103002/20001
3 years, 6 months ago (2017-05-30 15:05:13 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 15:10:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/844c8727744ff0b46ae67786feaa...

Powered by Google App Engine
This is Rietveld 408576698