Issue 2912093002: [vr] Exit VR mode when we encounter unsupported URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2912093002: [vr] Exit VR mode when we encounter unsupported URLs (Closed)

Created:
3 years, 6 months ago by Ian Vollick

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

[vr] Exit VR mode when we encounter unsupported URLs We currently do not handle URL elision, so we will exit VR mode. BUG=727373 Review-Url: https://codereview.chromium.org/2899393003 Cr-Original-Commit-Position: refs/heads/master@{#475501} Review-Url: https://codereview.chromium.org/2912093002 . Cr-Commit-Position: refs/branch-heads/3112@{#27} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/8c6c174cb89cdff17c4de402e67c5082636bfdd5

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -2 lines)			Patch
M	chrome/browser/android/vr_shell/textures/url_bar_texture.cc	View	1 chunk	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/android/vr_shell/ui_unsupported_mode.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/metrics/histograms/enums.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Ian Vollick

3 years, 6 months ago (2017-05-30 12:59:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c6c174cb89cdff17c4de402e67c5082636bfdd5.