Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2912053002: Make TextIterator constructor to take only proper range (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
Xiaocheng, blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextIterator constructor to take only proper range This patch makes |TextIterator| constructor to take only proper range to simplify code for improve code health. Note: This patch is passed all tests, but there are some cases to pass improper range to |TextIterator|. To catch such case and avoid infinite loop, we use |CHECK()| to make blink crash. BUG=727537 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912053002 Cr-Commit-Position: refs/heads/master@{#475819} Committed: https://chromium.googlesource.com/chromium/src/+/984f4b2c4df57ae840917a1d79f95a54e68e2c7b

Patch Set 1 : 2017-05-30T16:49:03 #

Patch Set 2 : 2017-05-31T12:36:26 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
yosin_UTC9
PTAL PS#1, fixes bad callers, is already passed all tests. PS#2 is the latest patch.
3 years, 6 months ago (2017-05-31 03:57:21 UTC) #9
Xiaocheng
lgtm We can get rid of TI::Initialize after this patch.
3 years, 6 months ago (2017-05-31 04:08:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912053002/20001
3 years, 6 months ago (2017-05-31 05:56:36 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 06:00:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/984f4b2c4df57ae840917a1d79f9...

Powered by Google App Engine
This is Rietveld 408576698