Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2912043002: Remove PassRefPtr in ComputedStyle. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PassRefPtr in ComputedStyle. This patch removes the use of PassRefPtr in ComputedStyle where a PassRefPtr is returned by a function. BUG=494719 Review-Url: https://codereview.chromium.org/2912043002 Cr-Commit-Position: refs/heads/master@{#476215} Committed: https://chromium.googlesource.com/chromium/src/+/438c00ff3e08c0714d35999151142b805ddf643b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 5 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
shend
Hi Bugs, PTAL
3 years, 6 months ago (2017-05-30 07:41:25 UTC) #4
Bugs Nash
lgtm
3 years, 6 months ago (2017-06-01 00:00:26 UTC) #7
shend
Hi yutak, PTAL
3 years, 6 months ago (2017-06-01 00:03:14 UTC) #9
Yuta Kitamura
lgtm
3 years, 6 months ago (2017-06-01 05:17:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912043002/1
3 years, 6 months ago (2017-06-01 05:17:25 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 06:57:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/438c00ff3e08c0714d3599915114...

Powered by Google App Engine
This is Rietveld 408576698