Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 2911983003: Replace deprecated base::NonThreadSafe in chrome in favor of SequenceChecker. (Closed)

Created:
3 years, 6 months ago by gab
Modified:
3 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated base::NonThreadSafe in chrome in favor of SequenceChecker. Note to crash team: This CL is a refactor and has no intended behavior change. This change was scripted by https://crbug.com/676387#c8. Note-worthy for the reviewer: * SequenceChecker enforces thread-safety but not thread-affinity! If the classes that were updated are thread-affine (use thread local storage or a third-party API that does) they should be migrated to ThreadChecker instead. * ~NonThreadSafe() used to implcitly check in its destructor ~Sequence/ThreadChecker() doesn't by design. To keep this CL a no-op, an explicit check was added to the destructor of migrated classes. * NonThreadSafe used to provide access to subclasses, as such the |sequence_checker_| member was made protected rather than private where necessary. BUG=676387 This CL was uploaded by git cl split. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2911983003 Cr-Commit-Position: refs/heads/master@{#475417} Committed: https://chromium.googlesource.com/chromium/src/+/25894fe14877c00103c88e18ba0a57b41a076824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -50 lines) Patch
M chrome/browser/after_startup_task_utils.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 21 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton.h View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/process_singleton_startup_lock.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_startup_lock.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
gab
Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded across directories for OWNERS. ...
3 years, 6 months ago (2017-05-30 02:34:51 UTC) #2
Nico
lgtm
3 years, 6 months ago (2017-05-30 02:48:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911983003/1
3 years, 6 months ago (2017-05-30 02:48:39 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 03:40:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25894fe14877c00103c88e18ba0a...

Powered by Google App Engine
This is Rietveld 408576698