[Payments] Don't show error for intl phone from other country.

components/payments/core/payments_profile_comparator.cc

Index: components/payments/core/payments_profile_comparator.cc
diff --git a/components/payments/core/payments_profile_comparator.cc b/components/payments/core/payments_profile_comparator.cc
index e29576236aa5f4b7a986e4e464174059018ea043..3190bacf2a936b0e1087de751638464ddb732791 100644
--- a/components/payments/core/payments_profile_comparator.cc
+++ b/components/payments/core/payments_profile_comparator.cc
@@ -207,7 +207,9 @@ PaymentsProfileComparator::ComputeMissingFields(
 
   base::string16 phone = profile.GetInfo(
       autofill::AutofillType(autofill::PHONE_HOME_WHOLE_NUMBER), app_locale());
-  if (!autofill::IsValidPhoneNumber(phone, country))
+  base::string16 intl_phone = base::UTF8ToUTF16("+" + base::UTF16ToUTF8(phone));
+  if (!(autofill::IsValidPhoneNumber(phone, country) ||

[tmartino, 2017/05/30 21:52:57]

We should keep this consistent with what we do in the validation delegates for
Shipping + Contact editors

[sebsg, 2017/05/31 14:20:35]

Yep, it should already be the case. I modified the
GetFormattedPhoneNumberForDisplay method to check with the added "+" as well. 

For the editors themselves, Rouslan made a Cl to format the phone numbers, so
the + is added automatically.

[tmartino, 2017/05/31 14:48:14]

So basically are you saying the + is always passed along to:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/shippin...

?

[sebsg, 2017/05/31 17:50:25]

Not necessarily. Here is the distinction

When we get the number from disk, we want to add a + because it gets removed in
GetInfo and GetRawInfo for US and CA. That happens when we generate the labels
and when we fill editor fields with existing value.

When we validate what the user entered, we don't want to add a +. We validate
what the user entered as is.  

I know it's a bit convoluted :P But does that make sense? 

+        autofill::IsValidPhoneNumber(intl_phone, country)))
     missing |= kPhone;
 
   base::string16 email = profile.GetInfo(