[Payments] Don't show error for intl phone from other country.

components/payments/core/payments_profile_comparator.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/payments_profile_comparator.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "base/strings/utf_string_conversions.h"
@@ skipping 189 matching lines @@
   // Determine the country code to use when validating the phone number. Use
   // the profile's country if it has one, or the code for the app locale
   // otherwise. Note that international format numbers will always work--this
   // is just the region that will be used to check if the number is
   // potentially in a local format.
   std::string country =
       data_util::GetCountryCodeWithFallback(&profile, app_locale());
 
   base::string16 phone = profile.GetInfo(
       autofill::AutofillType(autofill::PHONE_HOME_WHOLE_NUMBER), app_locale());
-  if (!autofill::IsValidPhoneNumber(phone, country))
+  base::string16 intl_phone = base::UTF8ToUTF16("+" + base::UTF16ToUTF8(phone));
+  if (!(autofill::IsValidPhoneNumber(phone, country) ||

[tmartino, 2017/05/30 21:52:57]

We should keep this consistent with what we do in the validation delegates for
Shipping + Contact editors

[sebsg, 2017/05/31 14:20:35]

Yep, it should already be the case. I modified the
GetFormattedPhoneNumberForDisplay method to check with the added "+" as well. 

For the editors themselves, Rouslan made a Cl to format the phone numbers, so
the + is added automatically.

[tmartino, 2017/05/31 14:48:14]

So basically are you saying the + is always passed along to:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/shippin...

?

[sebsg, 2017/05/31 17:50:25]

Not necessarily. Here is the distinction

When we get the number from disk, we want to add a + because it gets removed in
GetInfo and GetRawInfo for US and CA. That happens when we generate the labels
and when we fill editor fields with existing value.

When we validate what the user entered, we don't want to add a +. We validate
what the user entered as is.  

I know it's a bit convoluted :P But does that make sense? 

+        autofill::IsValidPhoneNumber(intl_phone, country)))
     missing |= kPhone;
 
   base::string16 email = profile.GetInfo(
       autofill::AutofillType(autofill::EMAIL_ADDRESS), app_locale());
   if (!autofill::IsValidEmailAddress(email))
     missing |= kEmail;
 
   if (!AreRequiredAddressFieldsPresent(profile))
     missing |= kAddress;
 
@@ skipping 54 matching lines @@
   return GetContactCompletenessScore(p1) > GetContactCompletenessScore(p2);
 }
 
 bool PaymentsProfileComparator::IsShippingMoreComplete(
     const autofill::AutofillProfile* p1,
     const autofill::AutofillProfile* p2) const {
   return GetShippingCompletenessScore(p1) > GetShippingCompletenessScore(p2);
 }
 
 }  // namespace payments