Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2911963003: Restore disabled flaky tests of FileManager. (Closed)

Created:
3 years, 6 months ago by tetsui
Modified:
3 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, kouhei+script_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, hiroshige+script_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org, kochi+script_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore disabled flaky tests of FileManager. BUG=715961, 715963 TEST=out/Release/browser_tests '--gtest_filter=*FileManagerBrowserTest*' --gtest_repeat=40 Review-Url: https://codereview.chromium.org/2911963003 Cr-Commit-Position: refs/heads/master@{#481408} Committed: https://chromium.googlesource.com/chromium/src/+/6bc4b5accdea133c4b5de50e5ae7185ef6f483e4

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (21 generated)
tetsui
PTAL. Thanks! FileManagerBrowserTest ran 40 times w/o failure on ToT.
3 years, 6 months ago (2017-06-21 01:27:29 UTC) #15
fukino
lgtm
3 years, 6 months ago (2017-06-21 13:49:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911963003/40001
3 years, 6 months ago (2017-06-22 01:44:09 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 02:25:37 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6bc4b5accdea133c4b5de50e5ae7...

Powered by Google App Engine
This is Rietveld 408576698