test/cctest/test-object-observe.cc - Issue 291193005: Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-object-observe.cc

Issue 291193005: Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove EnsureHeapIterable and DisallocAllocation calls from LiveEdit::FindActiveGenerators Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-object-observe.cc

diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc

index a7b346fc6fea07da5cf3d0ff78b05d42698eead6..7c7893238f315197c5b8fd290248e5e2563e1e13 100644

--- a/test/cctest/test-object-observe.cc

+++ b/test/cctest/test-object-observe.cc

@@ -616,7 +616,6 @@ TEST(GetNotifierFromSameOrigin) {

static int GetGlobalObjectsCount() {

- CcTest::heap()->EnsureHeapIsIterable();

int count = 0;

i::HeapIterator it(CcTest::heap());

for (i::HeapObject* object = it.next(); object != NULL; object = it.next())

« src/heap-profiler.cc ('K') | « test/cctest/test-heap.cc ('k') | test/mjsunit/regress/regress-373283.js » ('j') | no next file with comments »