src/heap-profiler.cc - Issue 291193005: Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-profiler.cc

Issue 291193005: Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove EnsureHeapIterable and DisallocAllocation calls from LiveEdit::FindActiveGenerators Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-profiler.cc

diff --git a/src/heap-profiler.cc b/src/heap-profiler.cc

index 6068bf43bdad6abe6159261550bbc49a6059936d..4b7443a121ff9fde2eca25e15a8b9a831e65dfdb 100644

--- a/src/heap-profiler.cc

+++ b/src/heap-profiler.cc

@@ -173,9 +173,6 @@ void HeapProfiler::SetRetainedObjectInfo(UniqueId id,

Handle<HeapObject> HeapProfiler::FindHeapObjectById(SnapshotObjectId id) {

- heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,

yurys 2014/05/22 11:24:50 Does this mean that we don't need to call GC anymo

- "HeapProfiler::FindHeapObjectById");

- DisallowHeapAllocation no_allocation;

HeapObject* object = NULL;

HeapIterator iterator(heap(), HeapIterator::kFilterUnreachable);

// Make sure that object with the given id is still reachable.

« no previous file with comments | « src/heap.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »