Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 291193002: Revert "Fix Heap::IsHeapIterable." (Closed)

Created:
6 years, 7 months ago by Jarin
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Fix Heap::IsHeapIterable." This reverts commit r21387. TBR=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -80 lines) Patch
M src/debug.cc View 5 chunks +7 lines, -2 lines 0 comments Download
M src/heap.h View 3 chunks +1 line, -10 lines 0 comments Download
M src/heap.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/liveedit.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M src/runtime.cc View 7 chunks +40 lines, -36 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +1 line, -0 lines 0 comments Download
D test/mjsunit/regress/regress-373283.js View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jarin
6 years, 7 months ago (2014-05-20 14:04:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r21388 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698