Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/heap-profiler.cc

Issue 291193002: Revert "Fix Heap::IsHeapIterable." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap-profiler.cc
diff --git a/src/heap-profiler.cc b/src/heap-profiler.cc
index 4b7443a121ff9fde2eca25e15a8b9a831e65dfdb..6068bf43bdad6abe6159261550bbc49a6059936d 100644
--- a/src/heap-profiler.cc
+++ b/src/heap-profiler.cc
@@ -173,6 +173,9 @@ void HeapProfiler::SetRetainedObjectInfo(UniqueId id,
Handle<HeapObject> HeapProfiler::FindHeapObjectById(SnapshotObjectId id) {
+ heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,
+ "HeapProfiler::FindHeapObjectById");
+ DisallowHeapAllocation no_allocation;
HeapObject* object = NULL;
HeapIterator iterator(heap(), HeapIterator::kFilterUnreachable);
// Make sure that object with the given id is still reachable.
« no previous file with comments | « src/heap.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698