Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2911923002: Revert of Improve and fix counter texts (Closed)

Created:
3 years, 6 months ago by Guido Urdaneta
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve and fix counter texts (patchset #1 id:1 of https://codereview.chromium.org/2910983002/ ) Reason for revert: Breaks Linux Tests bot. See: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/57247 Sample logs: Google Test trace: ../../components/browsing_data/core/browsing_data_utils_unittest.cc:120: Test params: 0 password(s), 0 is_synced ../../components/browsing_data/core/browsing_data_utils_unittest.cc:122: Failure Expected: output Which is: None To be equal to: base:: Original issue's description: > Improve and fix counter texts > > Change all CBD counter texts to upper case first letter. > Replace cookie counter text for consistency with other counters. > > BUG=681523 > > Review-Url: https://codereview.chromium.org/2910983002 > Cr-Commit-Position: refs/heads/master@{#475344} > Committed: https://chromium.googlesource.com/chromium/src/+/818885262b08d3e4439c8ae538cec8090b5cdf2c TBR=msramek@chromium.org,maxwalker@chromium.org,dullweber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681523 Review-Url: https://codereview.chromium.org/2911923002 Cr-Commit-Position: refs/heads/master@{#475353} Committed: https://chromium.googlesource.com/chromium/src/+/b57e420cea18ea14d1217a167868687679a89d3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M components/browsing_data_strings.grdp View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Guido Urdaneta
Created Revert of Improve and fix counter texts
3 years, 6 months ago (2017-05-29 15:13:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911923002/1
3 years, 6 months ago (2017-05-29 15:13:23 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 15:13:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b57e420cea18ea14d1217a167868...

Powered by Google App Engine
This is Rietveld 408576698