Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2911853002: Refactor PDF ChunkStream and DocumentLoader code. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor PDF ChunkStream and DocumentLoader code. Add functions to make code more readable, and use more C++11. Review-Url: https://codereview.chromium.org/2911853002 Cr-Commit-Position: refs/heads/master@{#475655} Committed: https://chromium.googlesource.com/chromium/src/+/1d7b16f9b7854268e4a0ff8c94d5989fb84cd1ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -59 lines) Patch
M pdf/chunk_stream.h View 1 chunk +4 lines, -1 line 0 comments Download
M pdf/chunk_stream.cc View 7 chunks +30 lines, -38 lines 0 comments Download
M pdf/document_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/document_loader.cc View 6 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 6 months ago (2017-05-30 18:42:44 UTC) #6
dsinclair
lgtm
3 years, 6 months ago (2017-05-30 18:50:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911853002/1
3 years, 6 months ago (2017-05-30 18:53:34 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 20:25:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d7b16f9b7854268e4a0ff8c94d5...

Powered by Google App Engine
This is Rietveld 408576698