Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2767)

Issue 2911773002: Clean up unused grit header includes in chrome/ (Closed)

Created:
3 years, 2 months ago by Lei Zhang
Modified:
3 years, 2 months ago
Reviewers:
tommycli, Nico, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, jam, sadrul, yusukes+watch_chromium.org, tapted, tburkard+watch_chromium.org, rogerm+autofillwatch_chromium.org, hidehiko+watch_chromium.org, oka+watch_chromium.org, browser-components-watch_chromium.org, rginda+watch_chromium.org, skanuj+watch_chromium.org, lhchavez+watch_chromium.org, lgarron+watch_chromium.org, fukino+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, vakh+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, ios-reviews_chromium.org, grt+watch_chromium.org, sebsg+autofillwatch_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, Patrick Dubroy, nona+watch_chromium.org, noyau+watch_chromium.org, groby+spellwatch_chromium.org, rlp+watch_chromium.org, vabr+watchlistlogin_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, stevenjb+watch-md-settings_chromium.org, alemate+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, ntp-dev+reviews_chromium.org, jdonnelly+watch_chromium.org, rouslan+autofill_chromium.org, yamaguchi+watch_chromium.org, timvolodine, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, rouslan+spell_chromium.org, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, mlamouri+watch-permissions_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, dbeam+watch-downloads_chromium.org, sync-reviews_chromium.org, Matt Giuca, elijahtaylor+arcwatch_chromium.org, David Trainor- moved to gerrit, michaelpg+watch-options_chromium.org, jered+watch_chromium.org, kalyank, mathp+autofillwatch_chromium.org, tfarina, donnd+watch_chromium.org, shuchen+watch_chromium.org, asvitkine+watch_chromium.org, samarth+watch_chromium.org, dbeam+watch-history_chromium.org, David Black, pfeldman, victorhsieh+watch_chromium.org, mac-reviews_chromium.org, estade+watch_chromium.org, dbeam+watch-settings_chromium.org, James Su, alito+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up unused grit header includes in chrome/ Update list_unused_grit_header.py to deal with: - grit <then> tags - wrong variable when printing an error message Review-Url: https://codereview.chromium.org/2911773002 Cr-Commit-Position: refs/heads/master@{#476077} Committed: https://chromium.googlesource.com/chromium/src/+/edcd3171f41ef97eb94f4ca4acccaf616383d08d

Patch Set 1 #

Patch Set 2 : build, update #

Patch Set 3 : mac #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -221 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/android/devtools_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_external_updater.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/hats/hats_notification_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/low_disk_notification_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/ui/request_pin_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_infobar_delegate_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/notification/download_item_notification.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/notification/download_notification_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings_api_bubble_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gpu/three_d_api_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/mock_permission_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_bubble_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/page_info/connection_info_popup_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_resource_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/star_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/translate_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/confirm_bubble_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/external_protocol_dialog_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/select_file_dialog_impl_kde.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/page_info/page_info_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/page_info/page_info_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/page_info/permission_menu_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/automation_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ime/ime_window_frame_view.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/new_back_shortcut_bubble.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info/permission_selector_row.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_icon_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/reload_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/try_chrome_dialog_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/network_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/log_web_ui_url_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/power_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/settings_import_data_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/webapks_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/welcome_win10_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/plugins/non_loadable_plugin_placeholder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/resources/list_unused_grit_header.py View 1 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 36 (26 generated)
Lei Zhang
It's almost all grit #include removal.
3 years, 2 months ago (2017-05-30 20:30:42 UTC) #19
Nico
lgtm, nice!
3 years, 2 months ago (2017-05-30 20:44:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911773002/60001
3 years, 2 months ago (2017-05-30 20:45:42 UTC) #22
Lei Zhang
FWIW, this is probably 2-3 years worth of cruft. list_unused_grit_header.py results aren't 100% trustworthy because ...
3 years, 2 months ago (2017-05-30 20:46:35 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/451124)
3 years, 2 months ago (2017-05-30 21:00:26 UTC) #25
Lei Zhang
dbeam: webui set noparent stamp please.
3 years, 2 months ago (2017-05-30 21:04:58 UTC) #27
Lei Zhang
+tommycli for webui OWNERS.
3 years, 2 months ago (2017-05-31 19:29:57 UTC) #29
Dan Beam
lgtm
3 years, 2 months ago (2017-05-31 21:08:15 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911773002/60001
3 years, 2 months ago (2017-05-31 21:12:41 UTC) #32
commit-bot: I haz the power
3 years, 2 months ago (2017-05-31 22:51:13 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/edcd3171f41ef97eb94f4ca4accc...

Powered by Google App Engine
This is Rietveld 408576698