[DMC #25] Make DocumentMarker::GetType() virtual

third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h

Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h b/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
index 0db5e7a22e152d570777d253b73d308c350a0ca5..e14280ad716f389360ed30b205904bfe32114f41 100644
--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
@@ -46,10 +46,14 @@ class TextMatchMarker final : public DocumentMarker {
   TextMatchMarker(unsigned start_offset,
                   unsigned end_offset,
                   MatchStatus status)
-      : DocumentMarker(DocumentMarker::kTextMatch, start_offset, end_offset),
+      : DocumentMarker(start_offset, end_offset),
         match_status_(status),
         layout_state_(State::kInvalid) {}
 
+  // DocumentMarker implementations
+  MarkerType GetType() const { return DocumentMarker::kTextMatch; }

[yosin_UTC9, 2017/05/29 05:17:09]

We have an implementation of interface in ".cpp" file.

See "Stop inlining virtual methods" in
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts

+
+  // TextMatchMarker-specific
   bool IsActiveMatch() const { return match_status_ == MatchStatus::kActive; }
   void SetIsActiveMatch(bool active) {
     match_status_ = active ? MatchStatus::kActive : MatchStatus::kInactive;