Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h

Issue 2911733002: [DMC #25] Make DocumentMarker::GetType() virtual (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h b/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
index 0db5e7a22e152d570777d253b73d308c350a0ca5..e14280ad716f389360ed30b205904bfe32114f41 100644
--- a/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h
@@ -46,10 +46,14 @@ class TextMatchMarker final : public DocumentMarker {
TextMatchMarker(unsigned start_offset,
unsigned end_offset,
MatchStatus status)
- : DocumentMarker(DocumentMarker::kTextMatch, start_offset, end_offset),
+ : DocumentMarker(start_offset, end_offset),
match_status_(status),
layout_state_(State::kInvalid) {}
+ // DocumentMarker implementations
+ MarkerType GetType() const { return DocumentMarker::kTextMatch; }
yosin_UTC9 2017/05/29 05:17:09 We have an implementation of interface in ".cpp" f
+
+ // TextMatchMarker-specific
bool IsActiveMatch() const { return match_status_ == MatchStatus::kActive; }
void SetIsActiveMatch(bool active) {
match_status_ = active ? MatchStatus::kActive : MatchStatus::kInactive;

Powered by Google App Engine
This is Rietveld 408576698