Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2911663003: Verify story names for story sets with explicitly set names. (Closed)

Created:
3 years, 7 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify story names for story sets with explicitly set names. BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2911663003 Cr-Commit-Position: refs/heads/master@{#475929} Committed: https://chromium.googlesource.com/chromium/src/+/5dd8bd3e28d83ac7d744c6e00f7255cfde70d7f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/perf/page_sets/loading_desktop.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/trivial_sites.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ashleymarie1
Enabling the flag to check the story names for a few benchmarks that already explicitly ...
3 years, 6 months ago (2017-05-31 14:00:54 UTC) #3
nednguyen
lgtm
3 years, 6 months ago (2017-05-31 14:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911663003/1
3 years, 6 months ago (2017-05-31 14:34:03 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 15:58:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dd8bd3e28d83ac7d744c6e00f72...

Powered by Google App Engine
This is Rietveld 408576698