Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2911653002: Remove unused method in the native display service (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 6 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused method in the native display service This is in preparation for moving all the handler related methods from the native display service to the super class. BUG=720345 Review-Url: https://codereview.chromium.org/2911653002 Cr-Commit-Position: refs/heads/master@{#476002} Committed: https://chromium.googlesource.com/chromium/src/+/126e33d8b030ec43e0d1fe3a458da747c30bb7ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/notifications/native_notification_display_service.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/native_notification_display_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-26 14:34:54 UTC) #6
Peter Beverloo
lgtm
3 years, 6 months ago (2017-05-31 17:53:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911653002/1
3 years, 6 months ago (2017-05-31 17:53:54 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:34:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/126e33d8b030ec43e0d1fe3a458d...

Powered by Google App Engine
This is Rietveld 408576698