[Sync] Stop dropping pending restarts from interleaved nudges.

[Sync] Stop dropping pending restarts from interleaved nudges.

This bug was discovered by the Kitchen Sync integration test
BothClientsEnabledEncryptionAndChangedMultipleTimes_E2ETest. What was
happening is that for a given client, it was mid PostTask "bounce" in
TrySyncCycleJob, when a second nudge was scheduled. This was allowed to
get through because the pending_wakeup_timer_ wasn't running.

However, when TrySyncCycleJobImpl contacted the server, we hit an error,
and the scheduler tried to call RestartWaiting(). This didn't have any
effect, because now the pending_wakeup_timer_ has a imminent nudge,
with a smaller delay time, and we had no way of knowing the priority of
the pending wakeup tasks.

The above is arguably all okay, but when the now pending nudge was run,
it has low priority, but we're in an error state, and this no-ops. And
at the end of PerformDelayedNudge we explicitly don't call
RestartWaiting(), which seems to be wrong.

BUG=721850
Review-Url: https://codereview.chromium.org/2911603003
Cr-Commit-Position: refs/heads/master@{#475748}
Committed: https://chromium.googlesource.com/chromium/src/+/e14851b28b8df63f1a8d2b6ce65b9f8d754bc9f5

[skym, 2017-05-26 20:22:10]

Description was changed from

==========
[Sync] Stop dropping pending restarts from interleaved nudges.

BUG=721850
==========

to

==========
[Sync] Stop dropping pending restarts from interleaved nudges.

This bug was discovered by the Kitchen Sync integration test
BothClientsEnabledEncryptionAndChangedMultipleTimes_E2ETest. What was
happening is that for a given client, it was mid PostTask "bounce" in
TrySyncCycleJob, when a second nudge was scheduled. This was allowed to
get through because the pending_wakeup_timer_ wasn't running.

However, when TrySyncCycleJobImpl contacted the server, we hit an error,
and the scheduler tried to call RestartWaiting(). This didn't have any
effect, because now the pending_wakeup_timer_ has a imminent nudge,
with a smaller delay time, and we had no way of knowing the priority of
the pending wakeup tasks.

The above is arguably all okay, but when the now pending nudge was run,
it has low priority, but we're in an error state, and this no-ops. And
at the end of PerformDelayedNudge we explicitly don't call
RestartWaiting(), which seems to be wrong.

BUG=721850
==========

[skym, 2017-05-26 20:22:10]

skym@chromium.org changed reviewers:
+ gangwu@chromium.org

[skym, 2017-05-26 20:22:30]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-05-26 20:22:32]

PTAL

[commit-bot: I haz the power, 2017-05-26 20:22:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:23:09]

Dry run: This issue passed the CQ dry run.

[Gang Wu, 2017-05-30 19:37:20]

lgtm

[skym, 2017-05-30 19:44:42]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:45:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 23:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 23:06:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[skym, 2017-05-30 23:22:02]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-05-30 23:22:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:26:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496186522963450, "parent_rev":
"4eba08ea7191979e16f482ff78ce72597cbab6fa", "commit_rev":
"e14851b28b8df63f1a8d2b6ce65b9f8d754bc9f5"}

[commit-bot: I haz the power, 2017-05-31 02:26:59]

Description was changed from

==========
[Sync] Stop dropping pending restarts from interleaved nudges.

This bug was discovered by the Kitchen Sync integration test
BothClientsEnabledEncryptionAndChangedMultipleTimes_E2ETest. What was
happening is that for a given client, it was mid PostTask "bounce" in
TrySyncCycleJob, when a second nudge was scheduled. This was allowed to
get through because the pending_wakeup_timer_ wasn't running.

However, when TrySyncCycleJobImpl contacted the server, we hit an error,
and the scheduler tried to call RestartWaiting(). This didn't have any
effect, because now the pending_wakeup_timer_ has a imminent nudge,
with a smaller delay time, and we had no way of knowing the priority of
the pending wakeup tasks.

The above is arguably all okay, but when the now pending nudge was run,
it has low priority, but we're in an error state, and this no-ops. And
at the end of PerformDelayedNudge we explicitly don't call
RestartWaiting(), which seems to be wrong.

BUG=721850
==========

to

==========
[Sync] Stop dropping pending restarts from interleaved nudges.

This bug was discovered by the Kitchen Sync integration test
BothClientsEnabledEncryptionAndChangedMultipleTimes_E2ETest. What was
happening is that for a given client, it was mid PostTask "bounce" in
TrySyncCycleJob, when a second nudge was scheduled. This was allowed to
get through because the pending_wakeup_timer_ wasn't running.

However, when TrySyncCycleJobImpl contacted the server, we hit an error,
and the scheduler tried to call RestartWaiting(). This didn't have any
effect, because now the pending_wakeup_timer_ has a imminent nudge,
with a smaller delay time, and we had no way of knowing the priority of
the pending wakeup tasks.

The above is arguably all okay, but when the now pending nudge was run,
it has low priority, but we're in an error state, and this no-ops. And
at the end of PerformDelayedNudge we explicitly don't call
RestartWaiting(), which seems to be wrong.

BUG=721850

Review-Url: https://codereview.chromium.org/2911603003
Cr-Commit-Position: refs/heads/master@{#475748}
Committed:
https://chromium.googlesource.com/chromium/src/+/e14851b28b8df63f1a8d2b6ce65b...
==========

[commit-bot: I haz the power, 2017-05-31 02:27:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e14851b28b8df63f1a8d2b6ce65b...