Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2911583002: Generate enum/getters/setters/mappings for text-security. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for text-security. Currently, the text-security property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EWordBreak enum and use the generated CSSValueID <-> EWordBreak mappings. Diff of generated files: https://gist.github.com/darrnshn/2811407420cd06be91eca37e52c974d6/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2911583002 Cr-Commit-Position: refs/heads/master@{#474901} Committed: https://chromium.googlesource.com/chromium/src/+/dd404929f0f3d121a74361a394e1727fee2189a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -44 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-26 00:48:27 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-26 01:50:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911583002/1
3 years, 7 months ago (2017-05-26 03:45:34 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 03:49:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd404929f0f3d121a74361a394e1...

Powered by Google App Engine
This is Rietveld 408576698