Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2911533002: Use std::vector in process launch code. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::vector in process launch code. Instead of std::unique_ptr<char* []>. Review-Url: https://codereview.chromium.org/2911533002 Cr-Commit-Position: refs/heads/master@{#474877} Committed: https://chromium.googlesource.com/chromium/src/+/75fce5f4280450d1b54c47aa06235ae67bade43d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -78 lines) Patch
M base/process/launch_mac.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/process/launch_posix.cc View 4 chunks +80 lines, -73 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 7 months ago (2017-05-26 01:15:19 UTC) #6
scottmg
lgtm
3 years, 7 months ago (2017-05-26 01:54:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911533002/1
3 years, 7 months ago (2017-05-26 01:56:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 02:02:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75fce5f4280450d1b54c47aa0623...

Powered by Google App Engine
This is Rietveld 408576698