Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2911493002: cros: Pull user info from session_controller_client.mojom into separate mojom. (Closed)

Created:
3 years, 7 months ago by jdufault
Modified:
3 years, 7 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Pull user info from session_controller_client.mojom into separate mojom. User info needed by login/lock screen will be provided from mutliple sources, not just session_controller (ie, login uses user_manager, lock uses session_controller). BUG=719015 Review-Url: https://codereview.chromium.org/2911493002 Cr-Commit-Position: refs/heads/master@{#475193} Committed: https://chromium.googlesource.com/chromium/src/+/0933f4586224dd6de793b6118b763910e0a19d92

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ordering in typemaps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -149 lines) Patch
M ash/login/ui/lock_contents_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/public/interfaces/session_controller.mojom View 3 chunks +4 lines, -34 lines 0 comments Download
M ash/public/interfaces/session_controller.typemap View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/public/interfaces/session_controller_traits.h View 2 chunks +0 lines, -62 lines 0 comments Download
M ash/public/interfaces/typemaps.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
A ash/public/interfaces/user_info.mojom View 1 chunk +47 lines, -0 lines 0 comments Download
A ash/public/interfaces/user_info.typemap View 1 chunk +11 lines, -0 lines 0 comments Download
A ash/public/interfaces/user_info_traits.h View 1 chunk +76 lines, -0 lines 0 comments Download
M ash/session/session_controller.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M ash/session/session_controller_unittest.cc View 5 chunks +15 lines, -11 lines 0 comments Download
M ash/system/supervised/tray_supervised_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/system/user/user_card_view.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M ash/system/user/user_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_session_controller_client.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/session_controller_client.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/session_controller_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (15 generated)
jdufault
xiyuan@ PTAL
3 years, 7 months ago (2017-05-25 22:56:34 UTC) #5
xiyuan
lgtm https://codereview.chromium.org/2911493002/diff/1/ash/public/interfaces/typemaps.gni File ash/public/interfaces/typemaps.gni (right): https://codereview.chromium.org/2911493002/diff/1/ash/public/interfaces/typemaps.gni#newcode6 ash/public/interfaces/typemaps.gni:6: "//ash/public/interfaces/user_info.typemap", keep the list alpha-sorted
3 years, 7 months ago (2017-05-25 23:08:46 UTC) #6
jdufault
https://codereview.chromium.org/2911493002/diff/1/ash/public/interfaces/typemaps.gni File ash/public/interfaces/typemaps.gni (right): https://codereview.chromium.org/2911493002/diff/1/ash/public/interfaces/typemaps.gni#newcode6 ash/public/interfaces/typemaps.gni:6: "//ash/public/interfaces/user_info.typemap", On 2017/05/25 23:08:46, xiyuan wrote: > keep the ...
3 years, 7 months ago (2017-05-26 17:33:01 UTC) #11
jdufault
tsepez@: PTAL at mojom changes jamescook@: PTAL (need owner approval)
3 years, 7 months ago (2017-05-26 17:37:01 UTC) #13
Tom Sepez
RS LGTM on moving existing stuff around.
3 years, 7 months ago (2017-05-26 17:57:59 UTC) #14
James Cook
LGTM
3 years, 7 months ago (2017-05-26 23:35:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911493002/20001
3 years, 7 months ago (2017-05-26 23:39:45 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 23:44:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0933f4586224dd6de793b6118b76...

Powered by Google App Engine
This is Rietveld 408576698