Expose transport RTT estimate from Network Quality Estimator (NQE)

Expose transport RTT estimate from Network Quality Estimator (NQE)

This will later be used to set proxy connection timeouts.

BUG=704339
Review-Url: https://codereview.chromium.org/2911473002
Cr-Commit-Position: refs/heads/master@{#474920}
Committed: https://chromium.googlesource.com/chromium/src/+/10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d

[tbansal1, 2017-05-25 22:38:51]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2017-05-25 22:38:57]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-05-25 22:39:30]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-25 22:39:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-25 22:41:10]

Description was changed from

==========
Expose transport RTT estimate frm NQE

BUG=
==========

to

==========
Expose transport RTT estimate from Network Quality Estimator (NQE)

This will later be used to set proxy connection timeouts.

BUG=704339
==========

[tbansal1, 2017-05-25 22:41:33]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-05-25 22:41:34]

ryansturm: ptal. Thanks.

[RyanSturm, 2017-05-25 23:05:50]

lgtm % nit. Would be better in the CL that uses it IMO, but I won't push back on
that.

https://codereview.chromium.org/2911473002/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2911473002/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.h:345: // the returned optional value is null.
nit:s/value is null/has no value/

[tbansal1, 2017-05-26 01:29:28]

https://codereview.chromium.org/2911473002/diff/40001/net/nqe/network_quality...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2911473002/diff/40001/net/nqe/network_quality...
net/nqe/network_quality_estimator.h:345: // the returned optional value is null.
On 2017/05/25 23:05:50, RyanSturm wrote:
> nit:s/value is null/has no value/

Done.

[tbansal1, 2017-05-26 01:29:31]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-05-26 01:29:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2911473002/#ps60001
(title: "ryansturm comment")

[commit-bot: I haz the power, 2017-05-26 01:29:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:23:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495762171966110,
"parent_rev": "0ffd86f3ca15a4728605fa70435297d334ccc35a", "commit_rev":
"10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d"}

[commit-bot: I haz the power, 2017-05-26 05:23:22]

Description was changed from

==========
Expose transport RTT estimate from Network Quality Estimator (NQE)

This will later be used to set proxy connection timeouts.

BUG=704339
==========

to

==========
Expose transport RTT estimate from Network Quality Estimator (NQE)

This will later be used to set proxy connection timeouts.

BUG=704339

Review-Url: https://codereview.chromium.org/2911473002
Cr-Commit-Position: refs/heads/master@{#474920}
Committed:
https://chromium.googlesource.com/chromium/src/+/10cfdc03a41bf1808feaacb0a664...
==========

[commit-bot: I haz the power, 2017-05-26 05:23:23]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/10cfdc03a41bf1808feaacb0a664...