Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 2911393002: Nix GetRootWindowController, use RootWindowController::ForWindow. (Closed)

Created:
3 years, 6 months ago by msw
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, je_julie, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dcheng, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Nix GetRootWindowController, use RootWindowController::ForWindow. Also remove WmWindow::GetRootWindowController. Also perform some minor cleanup/refactoring. BUG=NONE TEST=No functional changes. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2911393002 Cr-Commit-Position: refs/heads/master@{#476137} Committed: https://chromium.googlesource.com/chromium/src/+/257a6a2397aab389408c5f096c506c1c83dccc1a

Patch Set 1 #

Patch Set 2 : Cleanup; remove WmWindow::GetRootWindowController #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : cleanup #

Patch Set 5 : Sync and rebase. #

Total comments: 2

Patch Set 6 : Replace conditional with DCHECK. #

Patch Set 7 : Update unit test and fix GetRootWindowControllerWithDisplayId. #

Patch Set 8 : Sync and rebase AGAIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -109 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/accelerators/exit_warning_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/cursor_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_util_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/top_level_window_factory.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 2 3 4 5 6 7 2 chunks +1 line, -7 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -6 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 3 4 5 6 2 chunks +11 lines, -11 lines 0 comments Download
M ash/screen_util.cc View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M ash/shelf/shelf.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 5 chunks +6 lines, -9 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 6 chunks +14 lines, -18 lines 0 comments Download
M ash/system/toast/toast_overlay.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_keyboard_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 35 (25 generated)
msw
Hey Scott, please take a look; thanks!
3 years, 6 months ago (2017-05-31 19:26:58 UTC) #11
sky
LGTM https://codereview.chromium.org/2911393002/diff/120001/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/2911393002/diff/120001/ash/root_window_controller.cc#newcode314 ash/root_window_controller.cc:314: if (!window || !window->GetRootWindow()) It's unfortunate we need ...
3 years, 6 months ago (2017-05-31 21:12:44 UTC) #17
msw
https://codereview.chromium.org/2911393002/diff/120001/ash/root_window_controller.cc File ash/root_window_controller.cc (right): https://codereview.chromium.org/2911393002/diff/120001/ash/root_window_controller.cc#newcode314 ash/root_window_controller.cc:314: if (!window || !window->GetRootWindow()) On 2017/05/31 21:12:43, sky wrote: ...
3 years, 6 months ago (2017-05-31 21:23:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911393002/140001
3 years, 6 months ago (2017-05-31 21:24:29 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/397252)
3 years, 6 months ago (2017-05-31 22:43:08 UTC) #23
msw
I updated the unit test and made Shell::GetRootWindowControllerWithDisplayId() check for a null window (ie. from ...
3 years, 6 months ago (2017-06-01 00:55:05 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911393002/160001
3 years, 6 months ago (2017-06-01 00:56:29 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/281713) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-01 01:00:14 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911393002/180001
3 years, 6 months ago (2017-06-01 01:09:28 UTC) #32
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 01:46:45 UTC) #35
Message was sent while issue was closed.
Committed patchset #8 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/257a6a2397aab389408c5f096c50...

Powered by Google App Engine
This is Rietveld 408576698