Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2911373003: Wrap code into TextIterator::HandleRememberedProgress (Closed)

Created:
3 years, 6 months ago by Xiaocheng
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wrap code into TextIterator::HandleRememberedProgress TextIterator::Advance() used to contain some code before its main loop to handle the remembered progress, if any. This patch wraps the code into a new function TextIterator::HandleRememberedProgress() for better code health. Follow-up patches will utilize this function to make the control flow in TextIterator cleaner. BUG=721957 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2911373003 Cr-Commit-Position: refs/heads/master@{#475772} Committed: https://chromium.googlesource.com/chromium/src/+/4ac11ed7d02420bda817ec1441af56f2b56a0a02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 2 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 6 months ago (2017-05-31 01:30:14 UTC) #6
yosin_UTC9
lgtm
3 years, 6 months ago (2017-05-31 01:54:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911373003/1
3 years, 6 months ago (2017-05-31 01:55:25 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 03:35:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ac11ed7d02420bda817ec1441af...

Powered by Google App Engine
This is Rietveld 408576698