Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2911343002: Make PaintImages a class and implement a Clone() method. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PaintImages a class and implement a Clone() method. Currently we use Vector<Persistent<StyleImage>> to represent a list of paint images. When we generate StyleRareNonInheritedData, we need this type to have a Clone method because it is stored inside a std::unique_ptr. This patch makes this type its own class so that it can be extended with a Clone method. BUG=628043 Review-Url: https://codereview.chromium.org/2911343002 Cr-Commit-Position: refs/heads/master@{#476580} Committed: https://chromium.googlesource.com/chromium/src/+/9e887928f5fc67b86d3d2bf951c3022caaa2314e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/style/PaintImages.h View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (17 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-30 22:18:30 UTC) #3
meade_UTC10
lgtm oh lol should do this before the other CL you sent me
3 years, 6 months ago (2017-05-31 06:00:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911343002/20001
3 years, 6 months ago (2017-06-02 05:24:34 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 05:29:13 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e887928f5fc67b86d3d2bf951c3...

Powered by Google App Engine
This is Rietveld 408576698