Update the analysis server diagnostic page - re-enable code completion and overlay pages,

Update the analysis server diagnostic page - re-enable code completion and overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c817241ad69138237d83e7d1381cfd5055b16967

[devoncarew, 2017-05-30 20:42:20]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[devoncarew, 2017-05-30 20:42:21]

Refactor the diagnostic page. This:

- re-enables the code completion statistics
- re-enables the overlay information

and

- updates the css and navigation, borrowing the look from github's (open source)
Primer css: http://primercss.io/

[scheglov, 2017-05-30 21:02:00]

LGTM

[Brian Wilkerson, 2017-05-30 21:09:20]

lgtm

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:146:
a.title.toLowerCase().compareTo(a.title.toLowerCase())));
One of these 'a's should be a 'b'.

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:259: if (detail != null)
buf.write('<span class="counter">$detail</span>');
style nit: We have a convention (within the analyzer packages) that we always
enclose nested statements in a block. It would be nice to preserve that.

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:263: buf.writeln('</div>');
// div.one-fourth
"one-fifth"? Consider dropping comments that can quickly become stale, like this
one (and the one on line 271).

[devoncarew, 2017-05-30 23:31:31]

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/diagnostics.dart (right):

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:146:
a.title.toLowerCase().compareTo(a.title.toLowerCase())));
On 2017/05/30 21:09:19, Brian Wilkerson wrote:
> One of these 'a's should be a 'b'.

oops

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:259: if (detail != null)
buf.write('<span class="counter">$detail</span>');
On 2017/05/30 21:09:19, Brian Wilkerson wrote:
> style nit: We have a convention (within the analyzer packages) that we always
> enclose nested statements in a block. It would be nice to preserve that.

Done.

https://codereview.chromium.org/2911313002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/diagnostics.dart:263: buf.writeln('</div>');
// div.one-fourth
On 2017/05/30 21:09:19, Brian Wilkerson wrote:
> "one-fifth"? Consider dropping comments that can quickly become stale, like
this
> one (and the one on line 271).

Done.

[devoncarew, 2017-05-31 01:46:39]

Description was changed from

==========
Update the analysis server diagnostic page - re-enable code completion and
overlay pages,
and refactor the css and navigation.

BUG=
==========

to

==========
Update the analysis server diagnostic page - re-enable code completion and
overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c817241ad69138237d83e7d1381cfd5055b16967
==========

[devoncarew, 2017-05-31 01:46:41]

Committed patchset #3 (id:40001) manually as
c817241ad69138237d83e7d1381cfd5055b16967 (presubmit successful).