Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: pkg/analysis_server/lib/src/server/http_server.dart

Issue 2911313002: Update the analysis server diagnostic page - re-enable code completion and overlay pages, (Closed)
Patch Set: small tweaks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/README.md ('k') | pkg/analysis_server/lib/src/status/diagnostics.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/http_server.dart
diff --git a/pkg/analysis_server/lib/src/server/http_server.dart b/pkg/analysis_server/lib/src/server/http_server.dart
index a8288fce7b55323531859e8d8b2d1fbf1f7fb03c..53a12e49c0e6f73f24675a8a8a486d363213101e 100644
--- a/pkg/analysis_server/lib/src/server/http_server.dart
+++ b/pkg/analysis_server/lib/src/server/http_server.dart
@@ -7,8 +7,8 @@ import 'dart:io';
import 'package:analysis_server/src/channel/web_socket_channel.dart';
import 'package:analysis_server/src/socket_server.dart';
+import 'package:analysis_server/src/status/diagnostics.dart';
import 'package:analysis_server/src/status/get_handler.dart';
-import 'package:analysis_server/src/status/get_handler2.dart';
/**
* Instances of the class [HttpServer] implement a simple HTTP server. The
@@ -96,8 +96,10 @@ class HttpAnalysisServer {
void _handleGetRequest(HttpRequest request) {
if (getHandler == null) {
if (socketServer.analysisServer.options.enableNewAnalysisDriver) {
- getHandler = new GetHandler2(socketServer, _printBuffer);
+ // TODO(devoncarew): Remove GetHandler2.
+ getHandler = new DiagnosticsSite(socketServer, _printBuffer);
} else {
+ // TODO(devoncarew): GetHandler is essentially dead code.
getHandler = new GetHandler(socketServer, _printBuffer);
}
}
@@ -146,3 +148,13 @@ class HttpAnalysisServer {
response.close();
}
}
+
+/**
+ * Instances of the class [AbstractGetHandler] handle GET requests.
+ */
+abstract class AbstractGetHandler {
+ /**
+ * Handle a GET request received by the HTTP server.
+ */
+ void handleGetRequest(HttpRequest request);
+}
« no previous file with comments | « pkg/analysis_server/README.md ('k') | pkg/analysis_server/lib/src/status/diagnostics.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698