Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2911263002: Rename network time policy to BrowserNetworkTimeQueriesEnabled (Closed)

Created:
3 years, 6 months ago by estark
Modified:
3 years, 6 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename network time policy to BrowserNetworkTimeQueriesEnabled Per https://codereview.chromium.org/2902603002/#msg28, we are only going to enable network time queries on non-ChromeOS desktop browsers. BUG=725232 Review-Url: https://codereview.chromium.org/2911263002 Cr-Commit-Position: refs/heads/master@{#476297} Committed: https://chromium.googlesource.com/chromium/src/+/9a1fe807fa28e16fadca9032239233dcd092aace

Patch Set 1 #

Total comments: 2

Patch Set 2 : disable policy on chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
estark
tnagel, PTAL?
3 years, 6 months ago (2017-05-30 17:35:41 UTC) #4
Thiemo Nagel
Thank you for the follow-up! https://codereview.chromium.org/2911263002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2911263002/diff/1/components/policy/resources/policy_templates.json#newcode9555 components/policy/resources/policy_templates.json:9555: 'supported_on': ['chrome.*:60-', 'chrome_os:60-'], Since ...
3 years, 6 months ago (2017-05-31 13:42:32 UTC) #7
estark
https://codereview.chromium.org/2911263002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2911263002/diff/1/components/policy/resources/policy_templates.json#newcode9555 components/policy/resources/policy_templates.json:9555: 'supported_on': ['chrome.*:60-', 'chrome_os:60-'], On 2017/05/31 13:42:32, Thiemo Nagel wrote: ...
3 years, 6 months ago (2017-06-01 04:00:45 UTC) #10
Thiemo Nagel
Lgtm. Thank you!
3 years, 6 months ago (2017-06-01 08:58:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911263002/20001
3 years, 6 months ago (2017-06-01 15:20:25 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 15:50:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a1fe807fa28e16fadca90322392...

Powered by Google App Engine
This is Rietveld 408576698