[Reland] Allow storing multiple replacements on SpellCheckResult

[Reland] Allow storing multiple replacements on SpellCheckResult

This CL was reverted because it did not properly handle the case where a
misspelling result is created with no suggested replacements. We want to
preserve misspelling results that don't include any suggested replacements, but
remove those that have some suggested replacements but they're all just changing
between different types of apostrophes.

Original CL:
https://codereview.chromium.org/2848943002

Revert:
https://codereview.chromium.org/2906243002

Original description:

Allow storing multiple replacements on SpellCheckResult

I'm working on adding support for the Android spellcheck suggestion list that
appears in a native text box when you tap on a misspelled word. It appears that
I need to modify this piece of infrastructure to support passing multiple
suggestions through to the Spelling marker that gets added.

For reference, we construct the SpellCheckResult objects from the Android
spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().

Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
again to get the list of suggestions that we might be able to use:
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da618a37d01167b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp#346

However, I talked to aelias and he said it would be better to store the
suggestions the first time we call the spellchecker, at the time we add the
marker, to avoid going back and forth unnecessarily.

BUG=715365, 727172
Review-Url: https://codereview.chromium.org/2911253003
Cr-Commit-Position: refs/heads/master@{#476644}
Committed: https://chromium.googlesource.com/chromium/src/+/455b156778ed1f2df63f8a14dff99399c88e475c

[rlanday, 2017-05-30 18:25:28]

rlanday@chromium.org changed reviewers:
+ noel@chromium.org, xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-05-30 18:25:38]

rlanday@chromium.org changed reviewers:
+ groby@chromium.org
- yosin@chromium.org

[rlanday, 2017-05-30 18:27:15]

groby@, xiaochengh@, noel@: does this fix for the bug look correct?

https://codereview.chromium.org/2911253003/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/spellcheck.cc (right):

https://codereview.chromium.org/2911253003/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/spellcheck.cc:502: if
(replacements_adjusted.empty() && !replacements.empty())
This is the fix for the bug:

Old check:
if (replacements_adjusted.empty())

New check:
if (replacements_adjusted.empty() && !replacements.empty())

https://codereview.chromium.org/2911253003/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/spellcheck_unittest.cc (right):

https://codereview.chromium.org/2911253003/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/spellcheck_unittest.cc:1217: // If we have no
suggested replacements, we should keep this misspelling.
This is a test case I'm adding for the case that was buggy

[rlanday, 2017-05-30 18:27:54]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 18:28:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 18:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:54:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-05-30 19:52:18]

Fixed build error in spell_check_host_impl_unittest.cc (a change was made after
I landed the original CL that added this test file and removed
spellcheck_message_filter_unittest.cc)

[rlanday, 2017-05-30 19:52:26]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 19:53:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 20:37:25]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Xiaocheng, 2017-05-30 20:51:29]

lgtm with a nit. Thanks for the fix!

Some off-topic discussion:

1. It doesn't seem good layering to filter misspellings due to typographical
apostrophe. Can we do it at a higher level? For example, we save an IPC message
if we do it in the browser process.

2. It seems that we don't have a full browser test for spellchecker. I think we
need one, since spellchecker goes through all layers of Chrome.

https://codereview.chromium.org/2911253003/diff/20001/components/spellcheck/r...
File components/spellcheck/renderer/spellcheck.cc (right):

https://codereview.chromium.org/2911253003/diff/20001/components/spellcheck/r...
components/spellcheck/renderer/spellcheck.cc:486: std::vector<WebString>
replacements_adjusted;
nit: It seems better to move L486-503 to a wrapper function in the anonymous
namespace, so that SpellCheck::CreateTextCheckingResults looks cleaner.

[rlanday, 2017-05-30 21:48:19]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-30 21:48:45]

https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
File components/spellcheck/renderer/spellcheck.cc (right):

https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
components/spellcheck/renderer/spellcheck.cc:116: std::vector<WebString>
FilterReplacementSuggestions(
Ok, I've filtered out this logic into a helper function

[commit-bot: I haz the power, 2017-05-30 21:49:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[groby-ooo-7-16, 2017-05-31 00:04:15]

lgtm

[rlanday, 2017-05-31 00:11:49]

rlanday@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:12:11]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-05-31 00:13:54]

jochen@, mkwst@: this CL is a reland of
https://codereview.chromium.org/2848943002. I don't believe I've changed any of
the files I asked either of you to review. In hindsight I probably should've
re-opened the original CL (I wasn't aware I could do that).

jochen@, you reviewed:
  chrome/browser/renderer_context_menu/spelling_menu_observer.cc
  content/shell/test_runner/mock_spell_check.cc
  content/shell/test_runner/spell_check_client.cc
  third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
  third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
  third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
  third_party/WebKit/Source/platform/text/TextChecking.h
  third_party/WebKit/Source/web/WebTextCheckingResult.cpp
  third_party/WebKit/public/web/WebTextCheckingResult.h

mkwst@, you reviewed:
  components/spellcheck/common/spellcheck_messages.h

[Xiaocheng, 2017-05-31 02:05:25]

https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
File components/spellcheck/renderer/spellcheck.cc (right):

https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
components/spellcheck/renderer/spellcheck.cc:121: // Use the same types of
appostrophes as in the mispelled word.
nit: s/appostrophes/apostrophes/

[rlanday, 2017-05-31 02:14:02]

On 2017/05/31 at 02:05:25, xiaochengh wrote:
>
https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
> File components/spellcheck/renderer/spellcheck.cc (right):
> 
>
https://codereview.chromium.org/2911253003/diff/40001/components/spellcheck/r...
> components/spellcheck/renderer/spellcheck.cc:121: // Use the same types of
appostrophes as in the mispelled word.
> nit: s/appostrophes/apostrophes/

Fixed

[rlanday, 2017-05-31 02:14:04]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 02:14:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 04:10:13]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-05-31 04:47:12]

Still LGTM.

[Noel Gordon, 2017-05-31 05:46:21]

Lots of tests here, but no layout test or unit test complained when the original
patch was landed ... bug discovered later (727172)

Do we have a test covering bug https://crbug.com/727172 ?

https://codereview.chromium.org/2911253003/diff/80001/chrome/browser/spellche...
File chrome/browser/spellchecker/spell_check_host_impl_unittest.cc (right):

https://codereview.chromium.org/2911253003/diff/80001/chrome/browser/spellche...
chrome/browser/spellchecker/spell_check_host_impl_unittest.cc:91:
EXPECT_EQ(service_results[i].replacements, results[i].replacements);
x[i].replacements -> x[i].replacements[0] here I think.

https://codereview.chromium.org/2911253003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebTextCheckingResult.cpp (right):

https://codereview.chromium.org/2911253003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebTextCheckingResult.cpp:43: Vector<String>
replacements_vec;
style: abbrv not allowed.

[rlanday, 2017-05-31 18:48:11]

On 2017/05/31 at 05:46:21, noel wrote:
> Lots of tests here, but no layout test or unit test complained when the
original patch was landed ... bug discovered later (727172)
> 
> Do we have a test covering bug https://crbug.com/727172 ?

I'm adding a test for this particular bug in this particular piece of code in
spellcheck_unittest.cc...it does seems a little bizarre though that you can
apparently entirely break Mac spellchecking and there's no test for that.
Probably would be a worthwhile follow-up task.

[rlanday, 2017-05-31 22:23:28]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-31 22:23:59]

On 2017/05/31 at 05:46:21, noel wrote:
>
https://codereview.chromium.org/2911253003/diff/80001/chrome/browser/spellche...
> File chrome/browser/spellchecker/spell_check_host_impl_unittest.cc (right):
> 
>
https://codereview.chromium.org/2911253003/diff/80001/chrome/browser/spellche...
> chrome/browser/spellchecker/spell_check_host_impl_unittest.cc:91:
EXPECT_EQ(service_results[i].replacements, results[i].replacements);
> x[i].replacements -> x[i].replacements[0] here I think.
> 
>
https://codereview.chromium.org/2911253003/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/WebTextCheckingResult.cpp (right):
> 
>
https://codereview.chromium.org/2911253003/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/WebTextCheckingResult.cpp:43: Vector<String>
replacements_vec;
> style: abbrv not allowed.

Updated

[commit-bot: I haz the power, 2017-05-31 22:24:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:44:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2017-06-01 06:27:42]

On 2017/05/31 18:48:11, rlanday wrote:
> On 2017/05/31 at 05:46:21, noel wrote:
> > Lots of tests here, but no layout test or unit test complained when the
> original patch was landed ... bug discovered later (727172)
> > 
> > Do we have a test covering bug https://crbug.com/727172 ?
> 
> I'm adding a test for this particular bug in this particular piece of code in
> spellcheck_unittest.cc...

Thank you.  I did not look in detail, I defer to spelling peeps for that. 

> it does seems a little bizarre though that you can
> apparently entirely break Mac spellchecking and there's no test for that.

Concur, bizarre.  A layout test would overcome any limitations of having unit
tests only (which, as we can in the current case, can fail to warn us).

> Probably would be a worthwhile follow-up task.

Yeap, please file a crbug to capture the details.

[Noel Gordon, 2017-06-01 10:34:56]

On 2017/06/01 06:27:42, noel gordon wrote:

> Yeap, please file a crbug to capture the details.

Rest LGTM.  Thanks for fixing.

[Noel Gordon, 2017-06-01 10:35:24]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 10:35:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 10:39:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 10:39:37]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2017-06-01 11:30:50]

The CQ bit was checked by noel@chromium.org

[Noel Gordon, 2017-06-01 11:30:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org, groby@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2911253003/#ps100001
(title: "Rebase, make changes requested by noel@")

[commit-bot: I haz the power, 2017-06-01 11:31:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 11:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 11:39:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Noel Gordon, 2017-06-01 12:00:56]

On 2017/06/01 11:39:20, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Missing LGTM from an OWNER for these files:
    chrome/browser/renderer_context_menu/spelling_menu_observer.cc

[Xiaocheng, 2017-06-01 15:42:07]

On 2017/06/01 at 06:27:42, noel wrote:
> On 2017/05/31 18:48:11, rlanday wrote:
> > On 2017/05/31 at 05:46:21, noel wrote:
> > > Lots of tests here, but no layout test or unit test complained when the
> > original patch was landed ... bug discovered later (727172)
> > > 
> > > Do we have a test covering bug https://crbug.com/727172 ?
> > 
> > I'm adding a test for this particular bug in this particular piece of code
in
> > spellcheck_unittest.cc...
> 
> Thank you.  I did not look in detail, I defer to spelling peeps for that. 
> 
> > it does seems a little bizarre though that you can
> > apparently entirely break Mac spellchecking and there's no test for that.
> 
> Concur, bizarre.  A layout test would overcome any limitations of having unit
tests only (which, as we can in the current case, can fail to warn us).

Unfortunately layout tests don't run code in components/spellcheck/, so it still
doesn't cover it...

I'm thinking a full browser test, since spellchecking goes through all layers of
Chrome.

> 
> > Probably would be a worthwhile follow-up task.
> 
> Yeap, please file a crbug to capture the details.

[rlanday, 2017-06-01 16:09:23]

I've filed a follow-up bug to add a test case: crbug.com/728659

[rlanday, 2017-06-01 20:54:09]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 20:54:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-01 20:55:19]

rlanday@chromium.org changed required reviewers:
+ jochen@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:17:54]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2017-06-02 05:00:51]

On 2017/06/01 15:42:07, Xiaocheng wrote:
> > > it does seems a little bizarre though that you can
> > > apparently entirely break Mac spellchecking and there's no test for that.
> > 
> > Concur, bizarre.  A layout test would overcome any limitations of having
unit
> tests only (which, as we can in the current case, can fail to warn us).
> 
> Unfortunately layout tests don't run code in components/spellcheck/, so it
still
> doesn't cover it...
> 
> I'm thinking a full browser test, since spellchecking goes through all layers
of
> Chrome.

Nod. Captured these thoughts in crbug.com/728659
 
> > noel@
> > Yeap, please file a crbug to capture the details.

> rlanday@	
I've filed a follow-up bug to add a test case: crbug.com/728659

Good stuff.  You're all good to go with this CL, once an OWNER of
chrome/browser/renderer_context_menu/spelling_menu_observer.cc
gives you an approve.

[Noel Gordon, 2017-06-02 05:02:21]

Description was changed from

==========
[Reland] Allow storing multiple replacements on SpellCheckResult

This CL was reverted because it did not properly handle the case where a
misspelling result is created with no suggested replacements. We want to
preserve misspelling results that don't include any suggested replacements, but
remove those that have some suggested replacements but they're all just changing
between different types of apostrophes.

Original CL:
https://codereview.chromium.org/2848943002

Revert:
https://codereview.chromium.org/2906243002

Original description:

Allow storing multiple replacements on SpellCheckResult

I'm working on adding support for the Android spellcheck suggestion list that
appears in a native text box when you tap on a misspelled word. It appears that
I need to modify this piece of infrastructure to support passing multiple
suggestions through to the Spelling marker that gets added.

For reference, we construct the SpellCheckResult objects from the Android
spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().

Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
again to get the list of suggestions that we might be able to use:
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...

However, I talked to aelias and he said it would be better to store the
suggestions the first time we call the spellchecker, at the time we add the
marker, to avoid going back and forth unnecessarily.

BUG=715365,727172
==========

to

==========
[Reland] Allow storing multiple replacements on SpellCheckResult

This CL was reverted because it did not properly handle the case where a
misspelling result is created with no suggested replacements. We want to
preserve misspelling results that don't include any suggested replacements, but
remove those that have some suggested replacements but they're all just changing
between different types of apostrophes.

Original CL:
https://codereview.chromium.org/2848943002

Revert:
https://codereview.chromium.org/2906243002

Original description:

Allow storing multiple replacements on SpellCheckResult

I'm working on adding support for the Android spellcheck suggestion list that
appears in a native text box when you tap on a misspelled word. It appears that
I need to modify this piece of infrastructure to support passing multiple
suggestions through to the Spelling marker that gets added.

For reference, we construct the SpellCheckResult objects from the Android
spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().

Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
again to get the list of suggestions that we might be able to use:
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...

However, I talked to aelias and he said it would be better to store the
suggestions the first time we call the spellchecker, at the time we add the
marker, to avoid going back and forth unnecessarily.

BUG=715365,727172
==========

[Noel Gordon, 2017-06-02 05:02:21]

noel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Noel Gordon, 2017-06-02 05:03:06]

On 2017/06/02 05:00:51, noel gordon wrote:
> > rlanday@	
> I've filed a follow-up bug to add a test case: crbug.com/728659
> 
> Good stuff.  You're all good to go with this CL, once an OWNER of
> chrome/browser/renderer_context_menu/spelling_menu_observer.cc
> gives you an approve.

+lazyboy for that ^^^

[jochen (gone - plz use gerrit), 2017-06-02 12:18:11]

lgtm

[Noel Gordon, 2017-06-02 14:42:11]

The CQ bit was checked by noel@chromium.org

[Noel Gordon, 2017-06-02 14:42:12]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
noel@chromium.org, mkwst@chromium.org, xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2911253003/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-02 14:42:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 14:48:13]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496414531760160,
"parent_rev": "a8c5ece43442461d33c6de07d574cff22a971b81", "commit_rev":
"455b156778ed1f2df63f8a14dff99399c88e475c"}

[commit-bot: I haz the power, 2017-06-02 14:48:22]

Description was changed from

==========
[Reland] Allow storing multiple replacements on SpellCheckResult

This CL was reverted because it did not properly handle the case where a
misspelling result is created with no suggested replacements. We want to
preserve misspelling results that don't include any suggested replacements, but
remove those that have some suggested replacements but they're all just changing
between different types of apostrophes.

Original CL:
https://codereview.chromium.org/2848943002

Revert:
https://codereview.chromium.org/2906243002

Original description:

Allow storing multiple replacements on SpellCheckResult

I'm working on adding support for the Android spellcheck suggestion list that
appears in a native text box when you tap on a misspelled word. It appears that
I need to modify this piece of infrastructure to support passing multiple
suggestions through to the Spelling marker that gets added.

For reference, we construct the SpellCheckResult objects from the Android
spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().

Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
again to get the list of suggestions that we might be able to use:
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...

However, I talked to aelias and he said it would be better to store the
suggestions the first time we call the spellchecker, at the time we add the
marker, to avoid going back and forth unnecessarily.

BUG=715365,727172
==========

to

==========
[Reland] Allow storing multiple replacements on SpellCheckResult

This CL was reverted because it did not properly handle the case where a
misspelling result is created with no suggested replacements. We want to
preserve misspelling results that don't include any suggested replacements, but
remove those that have some suggested replacements but they're all just changing
between different types of apostrophes.

Original CL:
https://codereview.chromium.org/2848943002

Revert:
https://codereview.chromium.org/2906243002

Original description:

Allow storing multiple replacements on SpellCheckResult

I'm working on adding support for the Android spellcheck suggestion list that
appears in a native text box when you tap on a misspelled word. It appears that
I need to modify this piece of infrastructure to support passing multiple
suggestions through to the Spelling marker that gets added.

For reference, we construct the SpellCheckResult objects from the Android
spellchecker results in SpellCheckerSessionBridge::ProcessSpellCheckResults().

Alternatively, ContextMenuClientImpl has logic for calling the spellchecker
again to get the list of suggestions that we might be able to use:
https://chromium.googlesource.com/chromium/src/+/adc8910776c64a876f0422454da6...

However, I talked to aelias and he said it would be better to store the
suggestions the first time we call the spellchecker, at the time we add the
marker, to avoid going back and forth unnecessarily.

BUG=715365,727172

Review-Url: https://codereview.chromium.org/2911253003
Cr-Commit-Position: refs/heads/master@{#476644}
Committed:
https://chromium.googlesource.com/chromium/src/+/455b156778ed1f2df63f8a14dff9...
==========

[commit-bot: I haz the power, 2017-06-02 14:48:24]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/455b156778ed1f2df63f8a14dff9...