Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2911223002: [Cronet] add missing certificate file for tests (Closed)

Created:
3 years, 6 months ago by pauljensen
Modified:
3 years, 6 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] add missing certificate file for tests Was added for new netty/tcnative in r467848, and needs to be included in Cronet test assets so Cronet tests can run. R=kapishnikov@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2911223002 Cr-Commit-Position: refs/heads/master@{#475560} Committed: https://chromium.googlesource.com/chromium/src/+/00797c765a5272808c6cafb3e165f401017f7cc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pauljensen
Andrei, PTAL, thank you!
3 years, 6 months ago (2017-05-30 14:41:23 UTC) #2
kapishnikov
lgtm
3 years, 6 months ago (2017-05-30 14:42:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911223002/1
3 years, 6 months ago (2017-05-30 15:18:01 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 16:49:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00797c765a5272808c6cafb3e165...

Powered by Google App Engine
This is Rietveld 408576698