Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2911213002: Setup ash_unittests --mash (Closed)

Created:
3 years, 6 months ago by jonross
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Setup ash_unittests --mash Have ash_unittests handle the --mash flag by setting up the internal config to be mash, as well as setting aura to be non-local. Create filter of blacklisted tests. Update bot configs for new test. TEST=ash_unittests --mash BUG=722544 Review-Url: https://codereview.chromium.org/2911213002 Cr-Commit-Position: refs/heads/master@{#475638} Committed: https://chromium.googlesource.com/chromium/src/+/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48

Patch Set 1 #

Patch Set 2 : update filter #

Total comments: 2

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -4 lines) Patch
M ash/test/ash_test_suite.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 chunk +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 chunk +12 lines, -0 lines 0 comments Download
M testing/buildbot/filters/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A testing/buildbot/filters/ash_unittests_mash.filter View 1 1 chunk +316 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jonross
Hey sky@ Could you take a look at this review for setting up ash_unittests --mash ...
3 years, 6 months ago (2017-05-30 15:49:00 UTC) #2
sky
LGTM https://codereview.chromium.org/2911213002/diff/20001/ash/test/ash_test_suite.cc File ash/test/ash_test_suite.cc (right): https://codereview.chromium.org/2911213002/diff/20001/ash/test/ash_test_suite.cc#newcode70 ash/test/ash_test_suite.cc:70: env_ = aura::Env::CreateInstance(is_mus | is_mash ? aura::Env::Mode::MUS | ...
3 years, 6 months ago (2017-05-30 17:34:31 UTC) #3
jonross
https://codereview.chromium.org/2911213002/diff/20001/ash/test/ash_test_suite.cc File ash/test/ash_test_suite.cc (right): https://codereview.chromium.org/2911213002/diff/20001/ash/test/ash_test_suite.cc#newcode70 ash/test/ash_test_suite.cc:70: env_ = aura::Env::CreateInstance(is_mus | is_mash ? aura::Env::Mode::MUS On 2017/05/30 ...
3 years, 6 months ago (2017-05-30 17:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911213002/40001
3 years, 6 months ago (2017-05-30 17:59:14 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 20:03:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8d1a3c75e20c8bdc048d29a30201...

Powered by Google App Engine
This is Rietveld 408576698